Use a fake timer in EventBus unit test for PageChangeEventSerializerTest::testCreatePageChangeVisibilityEvent
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Dec 16 2022, 2:42 AM

Description

A flaky test, a fake timer could help to get the same timestamp at all places
https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php81-docker/888/console

00:53:05 There was 1 failure:
00:53:05 
00:53:05 1) PageChangeEventSerializerTest::testCreatePageChangeVisibilityEvent
00:53:05 Failed asserting that two arrays are equal.
00:53:05 --- Expected
00:53:05 +++ Actual
00:53:05 @@ @@
00:53:05      'performer' => Array (...)
00:53:05      'revision' => Array (
00:53:05          'rev_id' => 29
00:53:05 -        'rev_dt' => '2022-12-15T23:43:55Z'
00:53:05 +        'rev_dt' => '2022-12-15T23:43:56Z'
00:53:05          'is_minor_edit' => false
00:53:05          'rev_sha1' => 'aqhji8gcje5j0y511s7kgskw3dd6qua'
00:53:05          'rev_size' => 9
00:53:05 
00:53:05 /workspace/src/extensions/EventBus/tests/phpunit/integration/Serializers/MediaWiki/PageChangeEventSerializerTest.php:189
00:53:05 /workspace/src/extensions/EventBus/tests/phpunit/integration/Serializers/MediaWiki/PageChangeEventSerializerTest.php:540
00:53:05 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:521

Details

	Subject	Repo	Branch	Lines +/-
	Set explicit revision timestamp in testCreatePageChangeVisibilityEvent	mediawiki/extensions/EventBus	master	+3 -0

Customize query in gerrit

Related Objects

Duplicates Merged Here: T325715: Time-dependent test in PageChangeEventSerializerTest

Event Timeline

Umherirrender created this task.Dec 16 2022, 2:42 AM

Restricted Application added a project: Data-Engineering. · View Herald TranscriptDec 16 2022, 2:42 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Umherirrender merged a task: T325715: Time-dependent test in PageChangeEventSerializerTest.Dec 21 2022, 5:12 PM

Umherirrender added subscribers: Ladsgroup, Ottomata.

• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Jan 6 2023, 11:00 AM

• EChetty moved this task from Backlog to Event Platform on the Data-Engineering-Planning board.Jan 6 2023, 12:14 PM

In case its impact it's not obvious: This is preventing us to merge patches in many repos without multiple tries.

Hm. The test here isn't relying on two different timers. This rev_dt is from a RevisionRecord provided by MediaWikiIntegrationTestCase's getExistingTestPage:

$wikiPage0 = $this->getExistingTestPage( 'MyPageToChangeVisibility' );

This test case does do

$revisionRecord = MutableRevisionRecord::newUpdatedRevisionRecord(...)

Both the expected value and the tested value are created from this $revisionRecord.

So I wonder if what is happening is that the new newUpdatedRevisionRecord does not have its timestamp set properly. Let's try setting it explicitly...

Change 876259 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@master] Set explicit revision timestamp in testCreatePageChangeVisibilityEvent

https://gerrit.wikimedia.org/r/876259

gerritbot added a project: Patch-For-Review.Jan 6 2023, 8:49 PM

Change 876259 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Set explicit revision timestamp in testCreatePageChangeVisibilityEvent

https://gerrit.wikimedia.org/r/876259

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2023, 4:32 PM

@Ladsgroup @Umherirrender did my change help?

In T325341#8562928, @Ottomata wrote:

@Ladsgroup @Umherirrender did my change help?

The error was not seen since some weeks, so lets take it as fixed. We can still reopen if needed.
Thanks for the fix!

Use a fake timer in EventBus unit test for PageChangeEventSerializerTest::testCreatePageChangeVisibilityEventClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Use a fake timer in EventBus unit test for PageChangeEventSerializerTest::testCreatePageChangeVisibilityEvent
Closed, ResolvedPublic
Actions