Page MenuHomePhabricator
Create Task
Maniphest T326869

Update TSP-owned products that may be affected by IP Masking
Open, Needs TriagePublic
Actions

Description

IP Masking will affect lots of our products, features, tools, gadgets, etc. This task is for tracking work to update those that are owned by Anti-Harassment, ahead of IP Masking being enabled on WMF sites.

See T326816: [Epic] Update features for temporary accounts, particularly What will be affected.

A preliminary investigation (T326759) has found that the following may be affected:

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 OpenTchandersT326869 Update TSP-owned products that may be affected by IP Masking
 OpenNoneT307060 [Epic] Temporary account AbuseFilter support
 ResolvedSTranT331653 Investigate: Update AbuseFilter for IP Masking
 ResolvedUmherirrenderT328311 Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links
 Resolved• AGueyteT335062 Update AbuseFilter with the right user verification
 Duplicate• AGueyteT335064 Investigate AbuseFilter Hook with CheckUser
 ResolvedSTranT334623 How do we log unsuccessful first edits for temporary users?
 ResolvedDreamy_JazzT357615 Create filters to distinguish anonymous/temporary/registered users
 ResolvedSTranT357772 Investigate: How will `ip_in_range` and `ip_in_ranges` function when temporary accounts are enabled
 ResolvedSTranT364833 Add `user_unnamed_ip` variable
 ResolvedSTranT363906 [Epic] Ensure filters that use PII-sensitive variables are protected
 ResolvedSTranT364465 Display changes to protected status and flags on AbuseFilter history and diff pages
 ResolvedSTranT364485 Alert a filter editor that a filter must be protected if it is saved with a protected variable
 ResolvedkostajhT365049 Investigate what to do about the AbuseFilter log revealing someone's IP address via historical logs
 ResolvedSTranT365743 Log when AbuseFilter user sees IP address associated with temp account via user_unnamed_ip variable trigger
 ResolvedTchandersT364902 How should access to IPs of temporary accounts be logged?
 ResolvedSTranT367390 Add granular query restrictions for AbuseFilter filter search
 ResolvedSTranT364834 Ensure testing tools that use `user_unnamed_ip` don't reveal it to users without the view right
 ResolvedSTranT369610 Give the `abusefilter-access-protected-vars` right to global maintainers
 OpensgrabarczukT369611 Coordinate the updates of IP-using AbuseFilter filters to use `user_unnamed_ip`
 ResolvedSTranT357774 Investigate: What to do with existing filters that temporary accounts will break
 ResolvedBUG REPORTDreamy_JazzT358632 CannotCreateActorException when creating a temporary account on an edit which causes an abuse filter log
 OpenSTranT365740 Document the changes introduced for temporary accounts
 Resolved• TThoabalaT331718 Undeploy SimilarEditors from Beta
 Resolved• TThoabalaT331749 Investigate: Update AntiSpoof for IP Masking
 Resolved• TThoabalaT336196 Don't store temporary user names in AntiSpoof's spoofuser table
 Resolved• AGueyteT331750 Investigate: Update SecurePoll for IP Masking
 ResolvedBUG REPORT• AGueyteT334421 BUG FIX: Display of SecurePoll logs
 ResolvedBUG REPORT• AGueyteT334490 SecurePoll Vote Details returns SQL Error
 Resolved• AGueyteT334597 Update User access to polls on SecurePoll
 Resolved• AGueyteT331751 Investigate: Update GlobalBlocking for IP Masking
 ResolvedCyndymediawiksimT331752 Investigate: Update CheckUser for IP Masking
 DuplicateNoneT332821 Should temporary users be treated as possible initiators of a check for the CheckUserLog
 ResolvedTchandersT330816 [Epic] Temporary users should not be assigned to user groups
 ResolvedTchandersT340457 In UserGroupManager::getUserImplicitGroups, add temporary users to a 'temp' group instead of the 'user' group
 Resolved• AGueyteT340458 Throw an error from API Userrights explaining that temporary users do not have groups
 ResolvedTchandersT340462 Special:UserRights should not list autopromote groups for temporary users
 ResolvedTchandersT340464 Prevent temporary users from being added to autopromote-once groups
 Resolved• AGueyteT340468 Throw an error from UserGroupManager::addUserToGroup if called on a temporary user
 Resolved• TThoabalaT340470 Investigate: UserGroupManager::addUserToGroup should not called on temporary users from WMF deployed extensions
 Resolved• AGueyteT340578 Ensure UserGroupManager::addUserToGroup is not called on temporary users from AbuseFilter extension
ResolvedNoneT340579 Ensure UserGroupManager::addUserToGroup is not called on temporary users from Flow extension
Resolved• TThoabalaT340580 Ensure UserGroupManager::addUserToGroup is not called on temporary users from Echo extension
Resolved• TThoabalaT340583 Ensure UserGroupManager::addUserToGroup is not called on temporary users from LdapAuthentication extension
Resolvedabi_T340584 Ensure UserGroupManager::addUserToGroup is not called on temporary users from Translate extension
Resolved• TThoabalaT340587 Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extension
Resolved• TThoabalaT340588 Ensure UserGroupManager::addUserToGroup is not called on temporary users from Wikibase extension
Invalid• TThoabalaT340616 Ensure User::addGroup is not called on temporary users from WikiLambda extension
 ResolvedNoneT340618 Ensure User::addGroup is not called on temporary users from CentralAuth extension
 ResolvedTchandersT341600 OutputPage::showPermissionsErrorPage should prompt temporary users to log in for certain actions

Event Timeline

Tchanders created this task.Jan 12 2023, 9:24 PM
Tchanders updated the task description. (Show Details)Jan 13 2023, 9:47 AM
STran claimed this task.Jan 17 2023, 6:32 PM
Tchanders added a comment.Jan 18 2023, 11:29 AM
  • SimilarEditors

I wonder if we could just un-deploy this for now, since work is stalled

ARamirez_WMF edited projects, added Anti-Harassment (AHaT Sprint 26: The Bycocket Hat); removed Anti-Harassment.Jan 25 2023, 7:09 PM
Tchanders added a subtask: T328311: Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links.Jan 30 2023, 2:38 PM
Tchanders added a subtask: T307060: [Epic] Temporary account AbuseFilter support.
ARamirez_WMF edited projects, added Anti-Harassment (AHT Sprint 27); removed Anti-Harassment (AHaT Sprint 26: The Bycocket Hat).Feb 28 2023, 6:52 PM
Tchanders mentioned this in T331718: Undeploy SimilarEditors from Beta.Mar 10 2023, 12:17 PM
Tchanders claimed this task.Mar 10 2023, 12:20 PM
Tchanders updated the task description. (Show Details)
Tchanders removed a subtask: T328311: Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links.
Tchanders added a subscriber: STran.
Tchanders edited projects, added Anti-Harassment; removed Anti-Harassment (AHT Sprint 27).Mar 10 2023, 12:22 PM
Tchanders updated the task description. (Show Details)Mar 10 2023, 9:17 PM
Tchanders closed subtask T331718: Undeploy SimilarEditors from Beta as Resolved.Apr 25 2023, 4:14 PM
Tchanders closed subtask T331749: Investigate: Update AntiSpoof for IP Masking as Resolved.Jun 20 2023, 1:41 PM
Tchanders closed subtask T331750: Investigate: Update SecurePoll for IP Masking as Resolved.
Tchanders closed subtask T331752: Investigate: Update CheckUser for IP Masking as Resolved.Jun 20 2023, 3:24 PM
Niharika closed subtask T331751: Investigate: Update GlobalBlocking for IP Masking as Resolved.Jun 24 2023, 1:36 AM
Tchanders renamed this task from Update AHT-owned products that may be affected by IP Masking to Update TSP-owned products that may be affected by IP Masking.Feb 5 2024, 3:08 PM
Tchanders removed a subtask: T331653: Investigate: Update AbuseFilter for IP Masking.Feb 7 2024, 10:23 AM
TAdeleye_WMF edited projects, added Trust and Safety Product Team; removed Anti-Harassment.May 14 2024, 4:16 PM
kostajh moved this task from Inbox to Ready on the Temporary accounts board.Sep 10 2024, 1:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits