Remove convinence link to "checks by this user" on Special:Contribution pages of temporary accounts
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Cyndymediawiksim
	May 11 2023, 3:09 PM

Description

The CheckUser extension adds a convenience link from Special:Contributions of a user to the list of all checks performed by that user. Temporary accounts cannot have user groups and therefore unless the wiki has set the * user group to have the checkuser right, temporary accounts would not be able to run a check.

Hiding this link will save on space on Special:Contributions and also brings temporary accounts inline with IP addresses.

Acceptance criteria

The checks by this user link is not shown on Special:Contributions when viewing the contributions of a temporary account

Details

	Subject	Repo	Branch	Lines +/-
	Hide "checks by this user" for temporary accounts	mediawiki/extensions/CheckUser	master	+269 -39

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 [Epic] Update features for temporary accounts
Resolved	Dreamy_Jazz	T336477 [Epic] Update CheckUser for temporary accounts
Resolved	Dreamy_Jazz	T336512 Remove convinence link to "checks by this user" on Special:Contribution pages of temporary accounts

Event Timeline

Cyndymediawiksim renamed this task from Update CheckUser for IP Masking to Exclude temporary users from being valid initiators for the CheckUser log query.May 11 2023, 3:09 PM

Cyndymediawiksim created this task.

Duplicated by / duplicates T332821? T332821 includes this and another fix that would be needed if temporary accounts are marked as invalid performers (specifically the "checks done by this user" link in Special:Contributions).

Cyndymediawiksim mentioned this in T336477: [Epic] Update CheckUser for temporary accounts.May 11 2023, 3:52 PM

Cyndymediawiksim updated the task description. (Show Details)May 17 2023, 1:50 PM

Dreamy_Jazz merged a task: T332821: Should temporary users be treated as possible initiators of a check for the CheckUserLog.May 23 2023, 5:20 PM

Dreamy_Jazz added subscribers: RhinosF1, Niharika.

Merged T332821 into this task. If this is done, as I've mentioned above, the link highlighted below should be removed from the contributions page of temporary accounts which is needs a different fix.

Dreamy_Jazz attached a referenced file: F37030386: special-contributions-for-temporary-account-as-checkuser.png. (Show Details)May 23 2023, 5:28 PM

Dreamy_Jazz claimed this task.Sep 11 2023, 9:55 AM

Dreamy_Jazz added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Change 956437 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Treat temporary users as invalid initiators for a check

https://gerrit.wikimedia.org/r/956437

gerritbot added a project: Patch-For-Review.Sep 11 2023, 1:55 PM

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 11 2023, 2:30 PM

Dreamy_Jazz renamed this task from Exclude temporary users from being valid initiators for the CheckUser log query to Remove convinence link to "checks by this user" on Special:Contribution pages of temporary accounts.Sep 25 2023, 11:10 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 956437 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Hide "checks by this user" for temporary accounts

https://gerrit.wikimedia.org/r/956437

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 1:11 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 29 2023, 9:06 AM

Suggested QA steps:

Install the CheckUser extension
Enable temporary account creation (this can be done by adding $wgAutoCreateTempUser['enabled'] = true; to your LocalSettings.php file)
Login to an account with the checkuserlog right (this can be done by giving the account the checkuser group).
Load the contributions page for an account (e.g. http://localhost:8080/wiki/Special:Contributions/Admin)

Verification step 1: Verify that a tool link with the text checks done by this user is shown in the toollinks near the top of the page.

Load the contributions page for a temporary account (e.g. http://localhost:8080/wiki/Special:Contributions/*Unregistered_1)

Verification step 2: Verify that the tool link with the text checks done by this user is not shown.

The Checks done by this user link does not appear for temporary users and IPs. It does for regular users.

Test environment: local docker CheckUser 2.5 (45cf5bf) 00:35, 3 October 2023.

Niharika closed this task as Resolved.Nov 6 2023, 9:57 PM

	F37030386: special-contributions-for-temporary-account-as-checkuser.png
	May 23 2023, 5:27 PM

	Unknown Object (File)
	May 23 2023, 5:26 PM

Remove convinence link to "checks by this user" on Special:Contribution pages of temporary accountsClosed, ResolvedPublicActions