Notifications counter partially hidden
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	IKhitron
	May 11 2023, 7:19 PM

Description

Hi. Last week notifications icon code was changed. There are a couple of problems aftermath. The worst is that you can't see any more the counter if it's more than 9.

Have at least 10 notifications on the same wiki.
Open some wikipage with safemode.
Make sure you can see the correct counter.
Click on the notifications icon.
Expected: The same number remains.
Got: You can see the msd only.

Observed on Samsung Internet. Thank you.

Screenshot_20230511_220604_Samsung Internet.jpg (293×1 px, 87 KB)

QA Results - Beta

AC	Status	Details
1	✅	T336543#8890754

Details

	Subject	Repo	Branch	Lines +/-
	Ensure echo notifications counter is always visible	mediawiki/skins/Vector	master	+5 -0

Customize query in gerrit

Event Timeline

IKhitron created this task.May 11 2023, 7:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2023, 7:19 PM

Thanks for the report!

IKhitron updated the task description. (Show Details)May 12 2023, 2:42 PM

LGoto set the point value for this task to 2.May 15 2023, 5:24 PM

LGoto moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.May 22 2023, 5:28 PM

bwang claimed this task.May 23 2023, 5:00 PM

bwang moved this task from Ready for Development to Doing on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

bwang removed bwang as the assignee of this task.May 25 2023, 4:46 PM

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

Change 923388 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure echo notifications counter is always visible

https://gerrit.wikimedia.org/r/923388

gerritbot added a project: Patch-For-Review.May 25 2023, 4:46 PM

Jdlrobson assigned this task to Edtadros.May 25 2023, 7:19 PM

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.

Change 923388 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure echo notifications counter is always visible

https://gerrit.wikimedia.org/r/923388

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 25 2023, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 8:11 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Ventura
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

Have at least 10 notifications on the same wiki.
Open some wikipage with safemode.
Make sure you can see the correct counter.
Click on the notifications icon.
✅ AC1: Expected: The same number remains.

Screen Recording 2023-05-30 at 4.54.12 PM.mov.gif (754×1 px, 1 MB)

Edtadros updated the task description. (Show Details)May 30 2023, 11:57 PM

Jdrewniak claimed this task.Jun 1 2023, 4:36 PM

Jdrewniak closed this task as Resolved.Jun 6 2023, 2:02 PM

Jdrewniak moved this task from Ready for Signoff to QA in Production on the Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 4) board.Jun 6 2023, 4:43 PM

	F37085066: Screen Recording 2023-05-30 at 4.54.12 PM.mov.gif
	May 30 2023, 11:56 PM

	F36993078: Screenshot_20230511_220604_Samsung Internet.jpg
	May 11 2023, 7:19 PM