Page MenuHomePhabricator
Create Task
Maniphest T340587

Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extension
Closed, ResolvedPublic
Actions

Description

Following T340470, Ensure that UserGroupManager::addUserToGroup is not called on temporary users in MassMessage extension
Link to code search where calls are made can be found here

Details

SubjectRepoBranchLines +/-
Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extensionmediawiki/extensions/MassMessagemaster+1 -1
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
Restricted Task
 ResolvedkostajhT294511 2021 Security Team wikireplicas audit
 DeclinedNoneT284948 Raw IPs of logged-out users disclosed in wiki-replicas
 In ProgressNiharikaT324492 Temporary accounts - MVP
 OpenNoneT326816 [Epic] Update features for temporary accounts
 OpenTchandersT326869 Update TSP-owned products that may be affected by IP Masking
 OpenNoneT307060 [Epic] Temporary account AbuseFilter support
 ResolvedSTranT331653 Investigate: Update AbuseFilter for IP Masking
 ResolvedUmherirrenderT328311 Special:AbuseLog is missing the `mw-tempuserlink` class from temporary account user links
 Resolved• AGueyteT335062 Update AbuseFilter with the right user verification
 Duplicate• AGueyteT335064 Investigate AbuseFilter Hook with CheckUser
 ResolvedSTranT334623 How do we log unsuccessful first edits for temporary users?
 ResolvedDreamy_JazzT357615 Create filters to distinguish anonymous/temporary/registered users
 ResolvedSTranT357772 Investigate: How will `ip_in_range` and `ip_in_ranges` function when temporary accounts are enabled
 ResolvedSTranT364833 Add `user_unnamed_ip` variable
 ResolvedSTranT363906 [Epic] Ensure filters that use PII-sensitive variables are protected
 ResolvedSTranT364465 Display changes to protected status and flags on AbuseFilter history and diff pages
 ResolvedSTranT364485 Alert a filter editor that a filter must be protected if it is saved with a protected variable
 ResolvedkostajhT365049 Investigate what to do about the AbuseFilter log revealing someone's IP address via historical logs
 ResolvedSTranT365743 Log when AbuseFilter user sees IP address associated with temp account via user_unnamed_ip variable trigger
 ResolvedTchandersT364902 How should access to IPs of temporary accounts be logged?
 ResolvedSTranT367390 Add granular query restrictions for AbuseFilter filter search
 ResolvedSTranT364834 Ensure testing tools that use `user_unnamed_ip` don't reveal it to users without the view right
 ResolvedSTranT369610 Give the `abusefilter-access-protected-vars` right to global maintainers
 OpensgrabarczukT369611 Coordinate the updates of IP-using AbuseFilter filters to use `user_unnamed_ip`
 ResolvedSTranT357774 Investigate: What to do with existing filters that temporary accounts will break
 ResolvedBUG REPORTDreamy_JazzT358632 CannotCreateActorException when creating a temporary account on an edit which causes an abuse filter log
 OpenSTranT365740 Document the changes introduced for temporary accounts
 Resolved• TThoabalaT331718 Undeploy SimilarEditors from Beta
 Resolved• TThoabalaT331749 Investigate: Update AntiSpoof for IP Masking
 Resolved• TThoabalaT336196 Don't store temporary user names in AntiSpoof's spoofuser table
 Resolved• AGueyteT331750 Investigate: Update SecurePoll for IP Masking
 ResolvedBUG REPORT• AGueyteT334421 BUG FIX: Display of SecurePoll logs
 ResolvedBUG REPORT• AGueyteT334490 SecurePoll Vote Details returns SQL Error
 Resolved• AGueyteT334597 Update User access to polls on SecurePoll
 Resolved• AGueyteT331751 Investigate: Update GlobalBlocking for IP Masking
 ResolvedCyndymediawiksimT331752 Investigate: Update CheckUser for IP Masking
 DuplicateNoneT332821 Should temporary users be treated as possible initiators of a check for the CheckUserLog
 OpenNoneT331637 Update features in MediaWiki core for IP Masking
 ResolvedTchandersT330816 [Epic] Temporary users should not be assigned to user groups
 Resolved• TThoabalaT340470 Investigate: UserGroupManager::addUserToGroup should not called on temporary users from WMF deployed extensions
 Resolved• TThoabalaT340587 Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extension

Event Timeline

• TThoabala created this task.Jun 27 2023, 9:27 PM
• TThoabala claimed this task.Jul 2 2023, 1:17 AM
• TThoabala added a project: Anti-Harassment (AHaT Sprint 32 - Baseball Cap).
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 2 2023, 1:19 AM
gerritbot added a comment.Jul 2 2023, 1:21 AM

Change 934688 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/MassMessage@master] Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extension

https://gerrit.wikimedia.org/r/934688

gerritbot added a project: Patch-For-Review.Jul 2 2023, 1:21 AM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 2 2023, 1:39 AM
gerritbot added a comment.Jul 5 2023, 6:20 AM

Change 934688 abandoned by TsepoThoabala:

[mediawiki/extensions/MassMessage@master] Ensure UserGroupManager::addUserToGroup is not called on temporary users from MassMessage extension

Reason:

https://gerrit.wikimedia.org/r/934688

• TThoabala added a comment.Jul 5 2023, 6:22 AM

UserGroupManager::addUserToGroup is only called on the user set by this variable wgMassMessageAccountUsername. this can only be done by an admin and it is u likely that an admin can set this to a temporary username.

Maintenance_bot removed a project: Patch-For-Review.Jul 5 2023, 6:30 AM
• AGueyte moved this task from Code Review 🔍 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Jul 5 2023, 7:01 PM
Tchanders closed this task as Resolved.Aug 14 2023, 10:25 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits