Apply skin body styles to teleported elements
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Splitting out from Eric's comment to solve T345308 and future users of Codex dialogs.

In T345308#9134218, @egardner wrote:

Ideally the fix should be applied in Vector (and also separately in Minerva and any other skins you need to support) – the styles should be added to skinStyles/mediawiki.page.ready.less as skinStyle overrides.

See https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/952950 for an example of how to do this. I just don't know the full set of body styles that are expected. I'd recommend coordinating with Web to ensure that the correct body text styles from the skins can be inherited in this new location.

Acceptance criteria

Vector: Body styles are applied to teleported elements, so far only dialogs
Vector legacy: Body styles are applied to teleported elements, so far only dialogs
Minerva: Body styles are applied to teleported elements, so far only dialogs

Notes
The skin body styles live in different less files (typography and screen). We could add the vector-body class to the teleport target element or split body styles into mixins and reuse them in skinStyles/mediawiki.page.ready.less.

Details

Subject	Repo	Branch	Lines +/-
Apply body styles to teleported elements in vector legacy	mediawiki/skins/Vector	master	+3 -1
Apply content styles to mw teleport target	mediawiki/skins/MinervaNeue	master	+5 -1
Apply body styles to mw teleport target	mediawiki/skins/Vector	master	+4 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	egardner	T343476 Ensure that Codex Dialogs are compatible with Vector
		Resolved		Sgs	T347199 Apply skin body styles to teleported elements

Event Timeline

Sgs created this task.Sep 22 2023, 4:37 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptSep 22 2023, 4:37 PM

Sgs mentioned this in T345308: [minor] Praise-worthy mentees dialogs line height/spacing adjustments.Sep 22 2023, 4:41 PM

Change 960106 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/skins/Vector@master] [WIP] Apply body styles to mw teleport target

https://gerrit.wikimedia.org/r/960106

gerritbot added a project: Patch-For-Review.Sep 22 2023, 5:00 PM

I went ahead and added the vector-body class to the teleport target because using mediawiki.page.ready.less for already defined styles seems redundant but happy to rework to use mixins(?). Feedback from web team appreciated :) cc @Jdlrobson @Jdrewniak

Sgs renamed this task from Apply skin body styles to teleported dialogs to Apply skin body styles to teleported elements .Sep 22 2023, 5:06 PM

Sgs updated the task description. (Show Details)

Jdlrobson moved this task from Incoming to Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up) on the Web-Team-Backlog board.Sep 22 2023, 10:51 PM

Jdlrobson edited projects, added Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)); removed Web-Team-Backlog.

ovasileva triaged this task as Medium priority.Sep 25 2023, 5:23 PM

ovasileva set the point value for this task to 2.Sep 25 2023, 5:25 PM

ovasileva moved this task from Incoming to Ready for Development on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Sep 25 2023, 6:54 PM

kostajh subscribed.Sep 26 2023, 9:01 AM

Jdlrobson claimed this task.Sep 26 2023, 4:42 PM

Jdlrobson mentioned this in T339058: Zebra: VE surface widgets have too much padding on Vector Zebra.Sep 26 2023, 8:25 PM

Change 960106 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Apply body styles to mw teleport target

https://gerrit.wikimedia.org/r/960106

I've merged the above patch. I'm wondering if you also want to add the class for legacy Vector? I'm not sure if that's impacted by the same issue?

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.29; 2023-10-03).Sep 26 2023, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 26 2023, 9:10 PM

Jdlrobson reassigned this task from Jdlrobson to Sgs.Sep 27 2023, 9:30 PM

Change 961704 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/skins/Vector@master] Apply body styles to teleported elements in vector legacy

https://gerrit.wikimedia.org/r/961704

gerritbot added a project: Patch-For-Review.Sep 28 2023, 9:25 AM

Change 961729 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/skins/MinervaNeue@master] Apply content styles to mw teleport target

https://gerrit.wikimedia.org/r/961729

In T347199#9201250, @Jdlrobson wrote:

I've merged the above patch. I'm wondering if you also want to add the class for legacy Vector? I'm not sure if that's impacted by the same issue?

Thank you! Yes, the issue is present in all skins. I went ahead and did the same in Minerva and Vector legacy.

Sgs updated the task description. (Show Details)Sep 28 2023, 10:54 AM

Change 961704 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Apply body styles to teleported elements in vector legacy

https://gerrit.wikimedia.org/r/961704

Change 961729 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Apply content styles to mw teleport target

https://gerrit.wikimedia.org/r/961729

Jdlrobson moved this task from Blocked on Others to Ready for Signoff on the Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)) board.Sep 28 2023, 4:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 4:11 PM

KStoller-WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Oct 3 2023, 10:36 PM

KStoller-WMF moved this task from Incoming to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Web Team FY2023-24 Q1 Sprint 6.5 (Quarter wrap up)).Oct 3 2023, 11:21 PM

Jdlrobson moved this task from Incoming to Tracking on the Web-Team-Backlog board.

Checked (along with T345308) in testwiki wmf.29 - no regression issues found.

matmarex renamed this task from Apply skin body styles to teleported elements to Apply skin body styles to teleported elements.Oct 5 2023, 11:15 PM

matmarex subscribed.

matmarex mentioned this in T348286: Move the default OOUI overlay and window manager inside the MediaWiki teleport target.Oct 5 2023, 11:29 PM

matmarex mentioned this in T348287: Migrate all skin styles for .oo-ui-windowManager and .oo-ui-defaultOverlay to #mw-teleport-target.

I filed T348287 about doing this for other skins too (by taking advantage of the styles for OOUI dialogs that they already have).

Soap subscribed.Oct 6 2023, 5:24 AM

Jdlrobson mentioned this in T348572: Wrong font size in OOUI dropdowns in Vector.Oct 10 2023, 8:15 PM

Etonkovidova closed this task as Resolved.Dec 18 2023, 9:45 PM

Jack_who_built_the_house mentioned this in T369886: #mw-teleport-target in Monobook has low line-height.Jul 12 2024, 9:37 AM

Apply skin body styles to teleported elementsClosed, ResolvedPublic2 Estimated Story PointsActions