Page MenuHomePhabricator

Rollback doesn't actually work on UserBox: pages
Closed, ResolvedPublicBUG REPORT

Description

How very problematic.

The UI claims that everything went well and it even goes to show you a diff of the changes you - allegedly - did by rolling back edits, but when you go to the UserBox: page, nothing's changed, and when you look at the userbox in the Special:UserBoxes editing UI, you can furthermore see for yourself that nothing has indeed changed.

The "why?" is kinda obvious: regular MW editing interface has no real knowledge about the data stored on the fantag DB table, which is the only data the Special:UserBoxes UI cares about.

Also, caching probably plays a small role as well (i.e. besides touching the fantag DB table a rollback should also purge the relevant cache key(s) - I presume that after a rollback is complete, something like this should happen:

		$titleString = $some_title_object_representing_the_impacted_userbox_page->getDBkey(); // as per FanBox#__construct, which sets the class' $name property
		$cache = MediaWikiServices::getInstance()->getMainWANObjectCache();
		$key = $cache->makeKey( 'fantag', 'page', $titleString );
		$cache->delete( $key );

Event Timeline

Change #1046631 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/FanBoxes@master] Make rollback functional again

https://gerrit.wikimedia.org/r/1046631

Change #1055153 had a related patch set uploaded (by Jack Phoenix; author: Jack Phoenix):

[mediawiki/extensions/FanBoxes@master] Major architectural overhauling related to editing and viewing of old revisions of UserBox: pages

https://gerrit.wikimedia.org/r/1055153

Change #1055153 merged by jenkins-bot:

[mediawiki/extensions/FanBoxes@master] Major architectural overhauling related to editing and viewing of old revisions of UserBox: pages

https://gerrit.wikimedia.org/r/1055153

Change #1046631 abandoned by Jack Phoenix:

[mediawiki/extensions/FanBoxes@master] Make rollback functional again

Reason:

Obsolete in favor of https://gerrit.wikimedia.org/r/1055153 which got merged

https://gerrit.wikimedia.org/r/1046631

ashley claimed this task.
ashley removed a project: Patch-For-Review.