Page MenuHomePhabricator

Log when IPs are viewed on Special:GlobalContributions
Closed, ResolvedPublic

Description

From https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1075959

Dreamy Jazz
This log does not necessarily make it clear that the access was more than just on this wiki. Should we have a new log type to make this clear?

Tchanders
I agree with adding a new type, something like TemporaryAccountLogger::ACTION_VIEW_TEMPORARY_ACCOUNTS_ON_IP_GLOBAL.

Acceptance criteria:

  • new log type ACTION_VIEW_TEMPORARY_ACCOUNTS_ON_IP_GLOBAL is available
  • using Special:GC writes a log of this type
  • log is viewable from the checkuser-temporary-accounts log

TODO:

  • get sign off on text used for log?

Event Timeline

Change #1079282 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/CheckUser@master] Log when a user accesses temp accounts via Special:GlobalContributions

https://gerrit.wikimedia.org/r/1079282

Change #1079282 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Log when a user accesses temp accounts via Special:GlobalContributions

https://gerrit.wikimedia.org/r/1079282

dom_walden subscribed.

I tested looking up a number of IPs via Special:GlobalContributions and checking that a row had been added for the IP in the logging table. It has log_type=checkuser-temporary-account and log_action=view-temp-accounts-on-ip-global. This is regardless of whether Special:GlobalContributions actually returned any results.

I made a large number of concurrent requests to Special:GlobalContributions and did not find any missing log entries. However, I was only testing locally so the simulation of production loads is very limited.

I did this for IPv4 and IPv6, individual IPs and ranges. I see we normalise IP ranges when we insert them into the logging table and when we look them up for debouncing purposes.

The only potential duplication of log entries I found was when I looked up, for example, both 1.2.3.4 and 1.2.3.4/32 which was stored as two separate log entries. I don't think this is the end of the world.

I experimented setting a number of different parameters to the form and checking that the log entries are still made, in case they made any difference.

I only tested on a wiki with temporary accounts enabled, as Special:GlobalContributions was not available on wikis where it is disabled.

I could not test temporary or named accounts on Special:GlobalContributions. I assume this has yet to be implemented.

Test environment: Local docker CheckUser 2.5 (236b675) 16:08, 21 October 2024.