Page MenuHomePhabricator
Create Task
Maniphest T379880

Replies with discussion tools get partially deleted when deleting a line break
Open, Needs TriagePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable): write an answer using the "reply" button from DiscussionTools extension. Write some text, a line break and then some other text. Delete the line break.

What happens?: A part of the answer after the deleted line break will quietly disappear from preview but will stay visible in the input box. When publishing, the actual answer is the one that was previewed and content is lost.

What should have happened instead?: No part of the answer should vanish.

Other information (browser name/version, screenshots, etc.): Browser: Opera and Opera mobile. I always use the Wikicode , so I do not know if something similar can happen in visual mode.

Related Objects

Event Timeline

Escargot_rouge created this task.Thu, Nov 14, 6:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptThu, Nov 14, 6:49 AM
Esanders renamed this task from Replys with discussion tools get partly deleted when deleting a line break to Replies with discussion tools get partially deleted when deleting a line break.Thu, Nov 14, 8:11 AM
Esanders added projects: VisualEditor, VisualEditor-ContentEditable.EditedThu, Nov 14, 11:32 AM
Esanders added subscribers: dchan, Esanders.

Looks like a mobile backspace bug. Can reproduce in Chrome mobile:

image.png (1×473 px, 93 KB)

Also not specific to DT, happens in all VE instances.

Esanders added a comment.Thu, Nov 14, 11:35 AM

Porbably a duplicate of T202719.

dchan added a comment.Thu, Nov 14, 3:19 PM

This looks like an issue with Gboard in English (and many other languages, but not all).

Given <p>abc</p><p><CURSOR>def</p>, pressing backspace removes the second paragraph and appends "def" to the first paragraph, firing only input events without the selection focus ever being in the first paragraph.

This doesn't happen in some Gboard languages: instead, pressing backspace fires an actual keydown event with keyCode 8, so our emulated backspace handling can happen.

ppelberg assigned this task to dchan.Thu, Nov 14, 6:17 PM
ppelberg added a project: Editing-team (Kanban Board).
ppelberg moved this task from Incoming to Doing on the Editing-team (Kanban Board) board.
ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits