Xournal Code
Brought to you by:
andreasb123,
auroux
Menu
▾
▴
Code Merge Request #1: Adds ellipses to menu items & tooltips as per KDE and GNOME HIG (open)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Ben Ritter wants to merge 2 commits from /u/budgieinwa/xournal/ to master, 2014-08-04
Both the KDE and GNOME HIGs state that labels for menu items and buttons for which the action "requires further input from the user before it can be performed".
See https://techbase.kde.org/Projects/Usability/HIG/Labels#Using_Ellipses_in_Labels and https://developer.gnome.org/hig-book/3.5/menus-design.html.en (search in document for "ellipsis").
These changes add ellipses as per those guidelines.
I was unable to edit the glade file using glade (one version refused to load anything from the glade file and the other crashed when the file was opened) and as such, I have edited the file by hand. The edits are probably not quite right, but I hope these changes are useful enough for one of you devs to implement these changes.
| Commit | Date | |
|---|---|---|
|
[72867d]
(HEAD, master)
by
Added ellipses to tooltips for buttons as per HIG Added ellipses to the tooltip for buttons "Open" and "Set Zoom" as they require |
2014-08-04 04:53:35 | Tree |
|
[86e23e]
by
Added ellipses to menu items as per KDE and GNOME HIG Menu items that require extra user input before performing the primary function This commit is a bit shit in that it deviates from using stock items in many |
2014-08-04 04:45:34 | Tree |