Attachment 572407 Details for Bug 693948

[patch] patch

0001-bug-693948-css-tables-with-non-table-tag-should-be-l.patch (text/plain), 4.26 KB, created by Trevor Saunders (:tbsaunde)

(hide)

Description:

Filename:

MIME Type:

Creator: Trevor Saunders (:tbsaunde)

Size: 4.26 KB

patch

obsolete

>From fdba0e53f8d24fa61592745f110c18c98c40d3e9 Mon Sep 17 00:00:00 2001
>From: Trevor Saunders <trev.saunders@gmail.com>
>Date: Mon, 7 Nov 2011 04:05:51 -0500
>Subject: [PATCH] bug 693948 - css tables with non-table tag should be layout
> tables
>
>---
> accessible/src/html/nsHTMLTableAccessible.cpp      |    3 ++
> .../tests/mochitest/table/test_layoutguess.html    |   30 ++++++++++++++++++++
> 2 files changed, 33 insertions(+), 0 deletions(-)
>
>diff --git a/accessible/src/html/nsHTMLTableAccessible.cpp b/accessible/src/html/nsHTMLTableAccessible.cpp
>index 6951e44..5f1835e 100644
>--- a/accessible/src/html/nsHTMLTableAccessible.cpp
>+++ b/accessible/src/html/nsHTMLTableAccessible.cpp
>@@ -1387,6 +1387,9 @@ nsHTMLTableAccessible::IsProbablyForLayout(bool *aIsProbablyForLayout)
>     RETURN_LAYOUT_ANSWER(false, "Has role attribute, weak role, and role is table");
>   }
> 
>+  if (mContent->Tag() != nsGkAtoms::table)
>+    RETURN_LAYOUT_ANSWER(true, "html table without table tag");
>+
>   // Check if datatable attribute has "0" value.
>   if (mContent->AttrValueIs(kNameSpaceID_None, nsGkAtoms::datatable,
>                             NS_LITERAL_STRING("0"), eCaseMatters)) {
>diff --git a/accessible/tests/mochitest/table/test_layoutguess.html b/accessible/tests/mochitest/table/test_layoutguess.html
>index 459352c..cfdc5d7 100644
>--- a/accessible/tests/mochitest/table/test_layoutguess.html
>+++ b/accessible/tests/mochitest/table/test_layoutguess.html
>@@ -98,6 +98,11 @@
>       // layout table having datatable="0" attribute and containing data table structure (tfoot element)
>       testAttrs("table22", attr, true);
> 
>+      // css table with non-table tag
>+testAttrs("table23", attr, true);
>+testAttrs("table24", attr, true);
>+testAttrs("table24", attr, true);
>+
>       SimpleTest.finish();
>     }
> 
>@@ -431,5 +436,30 @@
>       </tr>
>     </tfoot>
>   </table>
>+  
>+  <div id="table23" style="display:table">
>+            <div style="display:table-row">
>+                      <div style="display:table-cell">Row 1, column 1</div>
>+                              <div style="display:table-cell">Row 1, column 2</div>
>+                                      <div style="display:table-cell">Row 1, column 3</div>
>+                                            </div>
>+                                                  <div style="display:table-row">
>+                                                            <div>Row 2, column 1</div>
>+                                                                    <div>Row 2, column 2</div>
>+                                                                            <div>Row 2, column 3</div>
>+                                                                                  </div>
>+                                                                                </div>
>+
>+                                                                                
>+                                                                                              <div id="table24" style="display:table">
>+                                                                                                      <div style="display:table-row">
>+                                                                                                                <div>Single-cell table with table-row</div>
>+                                                                                                                      </div>
>+                                                                                                                    </div>
>+
>+                                                                                                                    
>+                                                                                                                                  <div id="table25" style="display:table">
>+                                                                                                                                          <div style="display:table-cell">Single-cell table</div>
>+                                                                                                                                              </div>
> </body>
> </html>
>-- 
>1.7.7.1
>

Flags:

surkov: review+

Actions: View | Diff | Review

Attachments on bug 693948: 572407 | 577215