Attachment 577215 Details for Bug 693948

[patch] patch2 [for check in]

patch (text/plain), 3.17 KB, created by alexander :surkov (:asurkov)

(hide)

Description:

Filename:

MIME Type:

Creator: alexander :surkov (:asurkov)

Size: 3.17 KB

patch

obsolete

>diff --git a/accessible/src/html/nsHTMLTableAccessible.cpp b/accessible/src/html/nsHTMLTableAccessible.cpp
>--- a/accessible/src/html/nsHTMLTableAccessible.cpp
>+++ b/accessible/src/html/nsHTMLTableAccessible.cpp
>@@ -1409,16 +1409,19 @@ nsHTMLTableAccessible::IsProbablyForLayo
> 
>   if (mContent->HasAttr(kNameSpaceID_None, nsGkAtoms::role)) {
>     // Role attribute is present, but overridden roles have already been dealt with.
>     // Only landmarks and other roles that don't override the role from native
>     // markup are left to deal with here.
>     RETURN_LAYOUT_ANSWER(false, "Has role attribute, weak role, and role is table");
>   }
> 
>+  if (mContent->Tag() != nsGkAtoms::table)
>+    RETURN_LAYOUT_ANSWER(true, "table built by CSS display:table style");
>+
>   // Check if datatable attribute has "0" value.
>   if (mContent->AttrValueIs(kNameSpaceID_None, nsGkAtoms::datatable,
>                             NS_LITERAL_STRING("0"), eCaseMatters)) {
>     RETURN_LAYOUT_ANSWER(true, "Has datatable = 0 attribute, it's for layout");
>   }
> 
>   // Check for legitimate data table attributes.
>   nsAutoString summary;
>diff --git a/accessible/tests/mochitest/table/test_layoutguess.html b/accessible/tests/mochitest/table/test_layoutguess.html
>--- a/accessible/tests/mochitest/table/test_layoutguess.html
>+++ b/accessible/tests/mochitest/table/test_layoutguess.html
>@@ -93,16 +93,19 @@
>       testAttrs("table21.3", attr, true);
>       testAttrs("table21.4", attr, true);
>       testAttrs("table21.5", attr, true);
>       testAttrs("table21.6", attr, true);
> 
>       // layout table having datatable="0" attribute and containing data table structure (tfoot element)
>       testAttrs("table22", attr, true);
> 
>+      // css table with non-table tag
>+      testAttrs("table23", attr, true);
>+
>       SimpleTest.finish();
>     }
> 
>     SimpleTest.waitForExplicitFinish();
>     addA11yLoadEvent(doTest);
>   </script>
> </head>
> <body>
>@@ -112,16 +115,21 @@
>      title="Don't treat tables that have a landmark role as layout table">
>     Mozilla Bug 495388
>   </a>
>   <a target="_blank"
>      href="https://bugzilla.mozilla.org/show_bug.cgi?id=690222"
>      title="Data table elements used to determine layout-guess attribute shouldn't be picked from nested tables">
>     Mozilla Bug 690222
>   </a>
>+  <a target="_blank"
>+     href="https://bugzilla.mozilla.org/show_bug.cgi?id=693948"
>+     title="Expose layout-guess: true object attribute on CSS table accessible">
>+    Mozilla Bug 693948
>+  </a>
> 
>   <p id="display"></p>
>   <div id="content" style="display: none"></div>
>   <pre id="test">
>   </pre>
> 
>   
>   <table id="table1" role="grid">
>@@ -426,10 +434,19 @@
>   
>   <table id="table22" datatable="0">
>     <tfoot>
>       <tr>
>         <td>Cell1</td><td>cell2</td>
>       </tr>
>     </tfoot>
>   </table>
>+
>+  
>+  <div id="table23" style="display:table;">
>+    <div style="display:table-row;">
>+      <div style="display:table-cell;">Row 1, column 1</div>
>+      <div style="display:table-cell;">Row 1, column 2</div>
>+      <div style="display:table-cell;">Row 1, column 3</div>
>+    </div>
>+  </div>
> </body>
> </html>

Actions: View | Diff | Review

Attachments on bug 693948: 572407 | 577215