Attachment 8453315 Details for Bug 1024196

[patch] skia_bug_1024196

skia_bug_1024196 (text/plain), 1022 bytes, created by Walter Litwinczyk [:walter]

(hide)

Description:

Filename:

MIME Type:

Creator: Walter Litwinczyk [:walter]

Size: 1022 bytes

patch

obsolete

># HG changeset patch
># User Walter Litwinczyk <wlitwinczyk@mozilla.com>
># Date 1404938440 25200
>#      Wed Jul 09 13:40:40 2014 -0700
># Node ID 5a5fe8353870274ed4f923dfbdaddd201ca554aa
># Parent  2d88803a0b9c4a5356a9e14e8607777c0d1c431e
>Bug 1024196 - Fix leak of |i| variable in CreateGrGLInterfaceFromGLContext. r=gw280
>
>diff --git a/gfx/gl/SkiaGLGlue.cpp b/gfx/gl/SkiaGLGlue.cpp
>--- a/gfx/gl/SkiaGLGlue.cpp
>+++ b/gfx/gl/SkiaGLGlue.cpp
>@@ -773,16 +773,17 @@ static GrGLInterface* CreateGrGLInterfac
>     if (context->IsGLES()) {
>         i->fStandard = kGLES_GrGLStandard;
>     } else {
>         i->fStandard = kGL_GrGLStandard;
>     }
> 
>     GrGLExtensions extensions;
>     if (!extensions.init(i->fStandard, glGetString_mozilla, NULL, glGetIntegerv_mozilla)) {
>+        delete i;
>         return nullptr;
>     }
> 
>     i->fExtensions.swap(&extensions);
> 
>     // Core GL functions required by Ganesh
>     i->fFunctions.fActiveTexture = glActiveTexture_mozilla;
>     i->fFunctions.fAttachShader = glAttachShader_mozilla;

Flags:

gw280: review+

Actions: View | Diff | Review

Attachments on bug 1024196: 8453194 | 8453315