Closed
Bug 1156662
Opened 11 years ago
Closed 11 years ago
Identical code for different branches in nsStructuredCloneContainer.cpp
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1295227])
Attachments
(1 file, 1 obsolete file)
|
1.56 KB,
patch
|
Sylvestre
:
review+
|
Details | Diff | Splinter Review |
Bug 1154366 updated some of the code of nsStructuredCloneContainer.cpp
Now, we have same code in
nsresult nsStructuredCloneContainer::InitFromJSVal
cid 1295227
| Assignee | ||
Comment 1•11 years ago
|
||
I know that you don't do review but it landed recently and it landed in m-b.
(I wonder if it does not hide something).
Attachment #8595199 -
Flags: review?(bzbarsky)
Comment 2•11 years ago
|
||
Comment on attachment 8595199 [details] [diff] [review]
bug-1156662.diff
Oh, oops. Yeah, this branching can totally go away.
No need for that temporary false either. Just do:
bool success = JS_WriteStructuredClone(aCx, aData, &jsBytes, &mSize,
nullptr, nullptr,
JS::UndefinedHandleValue);
Attachment #8595199 -
Flags: review?(bzbarsky) → review+
| Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Updated•11 years ago
|
Attachment #8595199 -
Attachment is obsolete: true
Comment 4•11 years ago
|
||
Assignee: nobody → sledru
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 11 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
| Assignee | ||
Updated•8 years ago
|
Blocks: coverity-analysis
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•