Closed Bug 1113587 Opened 11 years ago Closed 11 years ago

Fire controllerchange event on controlled documents ServiceWorkerContainer

Categories

(Core :: DOM: Workers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: nsm, Assigned: nsm)

References

Details

Attachments

(1 file)

Fire controllerchange event on ServiceWorkerContainers
Comment on attachment 8539216 [details] [diff] [review] Fire controllerchange event on controlled documents ServiceWorkerContainer Review of attachment 8539216 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/workers/ServiceWorkerManager.cpp @@ +2093,5 @@ > + if (aValue != contextReg) { > + return PL_DHASH_NEXT; > + } > + > + nsCOMPtr<nsIDocument> aDoc = do_QueryInterface(aKey); doc @@ +2094,5 @@ > + return PL_DHASH_NEXT; > + } > + > + nsCOMPtr<nsIDocument> aDoc = do_QueryInterface(aKey); > + if (!aDoc) { if (NS_WARN_IF(!doc)) { .. ? @@ +2100,5 @@ > + } > + > + nsCOMPtr<nsPIDOMWindow> w = aDoc->GetWindow(); > + MOZ_ASSERT(w); > + nsGlobalWindow* window = static_cast<nsGlobalWindow*>(w.get()); auto* window ? @@ +2102,5 @@ > + nsCOMPtr<nsPIDOMWindow> w = aDoc->GetWindow(); > + MOZ_ASSERT(w); > + nsGlobalWindow* window = static_cast<nsGlobalWindow*>(w.get()); > + if (!window) { > + NS_WARNING("No valid nsGlobalWindow"); if (NS_WARN_IF(!window)) { .. ?
Attachment #8539216 - Flags: review?(amarchesini) → review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: