The Static Analysis tool Coverity detected that |aTarget| is dereferenced before begin null checked: >> IntSize size = aTarget->GetSize(); >> SetDimensions(size.width, size.height); >> >> if (aTarget) { >> mTarget = aTarget; >> mBufferProvider = new PersistentBufferProviderBasic(aTarget); >> } else { >> EnsureErrorTarget(); >> mTarget = sErrorTarget; >> } There is no posibility that in this context a null pointer dereference can occur since the context where InitializeWithDrawTarget gets called null check aTarget: >> RefPtr<DrawTarget> canvasTarget = >> drawTarget->CreateSimilarDrawTarget(size, drawTarget->GetFormat()); >> if (!canvasTarget) { >> continue; >> } >> >> nsICanvasRenderingContextInternal* ctx = canvas->GetContextAtIndex(0); >> if (!ctx) { >> continue; >> } >> >> // Initialize the context with the new DrawTarget. >> ctx->InitializeWithDrawTarget(nullptr, canvasTarget);

Comment on attachment 8783511 [details] Bug 1297054 - remove null check in CanvasRenderingContext2D::InitializeWithDrawTarget. https://reviewboard.mozilla.org/r/73304/#review71192 Can you change the signature of IntializeWithDrawTarget to use NotNull<gfx::DrawTarget*> aTarget?

Comment on attachment 8783511 [details] Bug 1297054 - remove null check in CanvasRenderingContext2D::InitializeWithDrawTarget. https://reviewboard.mozilla.org/r/73304/#review71194

Comment on attachment 8783511 [details] Bug 1297054 - remove null check in CanvasRenderingContext2D::InitializeWithDrawTarget. https://reviewboard.mozilla.org/r/73304/#review71696

Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/97158ba1395d remove null check in CanvasRenderingContext2D::InitializeWithDrawTarget. r=jrmuizel