Closed
Bug 1308868
Opened 10 years ago
Closed 7 years ago
[Static Analysis][Clang-Plugin] Ignore class members initialisation check - wave 2
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox52 wontfix)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | wontfix |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
Attachments
(7 files, 1 obsolete file)
|
58 bytes,
text/x-review-board-request
|
jrmuizel
:
review+
|
Details |
|
686 bytes,
patch
|
Details | Diff | Splinter Review | |
|
900 bytes,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
1.89 KB,
patch
|
edgar
:
review+
|
Details | Diff | Splinter Review |
|
663 bytes,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
|
744 bytes,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
|
1021 bytes,
patch
|
rillian
:
review+
|
Details | Diff | Splinter Review |
This is wave 2 - for Bug 1282408
As for some member variables we want to ignore it's initialisation check performed by clang-plugin - https://bugzilla.mozilla.org/show_bug.cgi?id=525063
We've added a flag for the declaration of each variable that we want to be ignored.
On this bug there will be posted patches of this kind.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
Comment 4•10 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799765 [details]
Bug 1308868 - Add ignore-initialization-check annotation to mPendingTextTrackChange from TextTrackList.
https://reviewboard.mozilla.org/r/84888/#review83506
::: dom/media/TextTrackList.h:70
(Diff revision 1)
>
> IMPL_EVENT_HANDLER(change)
> IMPL_EVENT_HANDLER(addtrack)
> IMPL_EVENT_HANDLER(removetrack)
>
> - bool mPendingTextTrackChange;
> + MOZ_INIT_OUTSIDE_CTOR bool mPendingTextTrackChange;
Isn't the warning telling us that on some constructor paths mPendingTrackChange isn't initialized? How about we just go:
bool mPendingTextTrackChange = false;
here, so it's alway initialized?
Attachment #8799765 -
Flags: review?(cpearce) → review-
| Assignee | ||
Updated•10 years ago
|
Attachment #8799765 -
Attachment is obsolete: true
| Comment hidden (mozreview-request) |
| Assignee | ||
Comment 6•10 years ago
|
||
MozReview-Commit-ID: FNTRHFpTx2E
Attachment #8801087 -
Flags: review?(jorendorff)
| Assignee | ||
Comment 7•10 years ago
|
||
MozReview-Commit-ID: 2dLsmPWeqSk
Attachment #8801095 -
Flags: review?(amarchesini)
| Assignee | ||
Comment 8•10 years ago
|
||
MozReview-Commit-ID: GT8oz6sCxaX
Attachment #8801099 -
Flags: review?(echen)
Updated•10 years ago
|
Attachment #8801095 -
Flags: review?(amarchesini) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b08765d5eb6
Add ignore-initialization-check annotation to mWorkerPrivate from ClientNavigateRunnable. r=baku
| Assignee | ||
Updated•10 years ago
|
Attachment #8801095 -
Flags: checkin+
Updated•10 years ago
|
Attachment #8801099 -
Flags: review?(echen) → review+
Comment 10•10 years ago
|
||
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba0be6c3f68a
Add ignore-initialization-check annotation to variables from TelephonyCall and TelephonyCallGroup. r=echen
| Assignee | ||
Updated•10 years ago
|
Attachment #8801099 -
Flags: checkin+
Comment 11•10 years ago
|
||
| bugherder | ||
| Assignee | ||
Comment 12•10 years ago
|
||
MozReview-Commit-ID: 1dIKcbbeStW
Attachment #8801702 -
Flags: review?(amarchesini)
Updated•10 years ago
|
Attachment #8801702 -
Flags: review?(amarchesini) → review+
Comment 13•10 years ago
|
||
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f65cc8c9aace
Add ignore-initialization-check annotation to mErrorCode from U2FStatus. r=baku
| Assignee | ||
Updated•10 years ago
|
Attachment #8801702 -
Flags: checkin+
| Assignee | ||
Comment 15•10 years ago
|
||
MozReview-Commit-ID: ZDCY7i19x5
Attachment #8802091 -
Flags: review?(adw)
| Assignee | ||
Comment 16•10 years ago
|
||
MozReview-Commit-ID: AYPnCUEtMrE
Attachment #8802097 -
Flags: review?(jwwang)
Comment 17•10 years ago
|
||
Comment on attachment 8802097 [details] [diff] [review]
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue
Review of attachment 8802097 [details] [diff] [review]:
-----------------------------------------------------------------
forward review to Ralph.
Attachment #8802097 -
Flags: review?(jwwang) → review?(giles)
Updated•10 years ago
|
Attachment #8802091 -
Flags: review?(adw) → review+
Comment 18•10 years ago
|
||
Comment on attachment 8802097 [details] [diff] [review]
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue
Review of attachment 8802097 [details] [diff] [review]:
-----------------------------------------------------------------
This is fine; the accesses are protected by the `IsAutoKeyword` tags. It would be better to convert these to a Variant type so the compiler checks for us, though.
Attachment #8802097 -
Flags: review?(giles) → review+
Comment 19•10 years ago
|
||
| bugherder | ||
Comment 20•10 years ago
|
||
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a7a506f5bb
Add ignore-initialization-check annotation to time from RecentURIKey. r=adw
| Assignee | ||
Updated•10 years ago
|
Attachment #8802091 -
Flags: checkin+
Comment 21•10 years ago
|
||
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37e81a1c152c
Add ignore-initialization-check annotation to mPosition and mLine from TextTrackCue. r=giles
| Assignee | ||
Updated•10 years ago
|
Attachment #8802097 -
Flags: checkin+
Comment 22•10 years ago
|
||
| bugherder | ||
Comment 23•10 years ago
|
||
| bugherder | ||
Comment 24•9 years ago
|
||
| mozreview-review | ||
Comment on attachment 8799342 [details]
Bug 1308868 - Add ignore-initialization-check annotation to members from TriangleTyped.
https://reviewboard.mozilla.org/r/84544/#review87488
Attachment #8799342 -
Flags: review?(jmuizelaar) → review+
Comment 25•9 years ago
|
||
Too late for firefox 52, mass-wontfix.
Updated•9 years ago
|
Attachment #8801087 -
Flags: review?(jorendorff)
Updated•8 years ago
|
Product: Core → Firefox Build System
Comment 26•7 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:andi, maybe it's time to close this bug?
Flags: needinfo?(bpostelnicu)
| Assignee | ||
Comment 27•7 years ago
|
||
Most of the work for this bug has already landed in m-c, an since now we will have coverity during review phase this is no longer necessary, so closing it.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(bpostelnicu)
Resolution: --- → FIXED
Updated•7 years ago
|
Keywords: leave-open
Updated•4 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•