Closed Bug 1551083 Opened 7 years ago Closed 7 years ago

Enable bugprone-move-forwarding-reference and fix the issues

Categories

(Developer Infrastructure :: Source Code Analysis, task, P3)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
task

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(2 external files)

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-move-forwarding-reference.html
forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead

We have only two references in the code.

Attachment #9064315 - Attachment description: Bug 1551083 - Fix two bugprone-move-forwarding-reference defects r?erahm → Bug 1551083 - Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r?erahm
Type: defect → task
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/030c742c25d5 Enable bugprone-move-forwarding-reference r=andi
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a15e072aac3f Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r=erahm

https://hg.mozilla.org/mozilla-central/rev/030c742c25d5
https://hg.mozilla.org/mozilla-central/rev/a15e072aac3f

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: