Upgrade to clang-{tidy,format} 8.0.0 (from 7.0.1)
Categories
(Developer Infrastructure :: Source Code Analysis, enhancement)
Tracking
(firefox68 fixed)
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
Attachments
(2 external files, 1 obsolete file)
| Assignee | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
In theory we should not have issues building our checkers against clang 8.0 since we did several patches in order to make our own code compliant with clang 8.0 trunk, please see [1]
Comment 3•7 years ago
|
||
Could you please also run:
./mach try fuzzy
and pick the static-analysis-autotest tasks for both win64 and linux64?
| Assignee | ||
Comment 4•7 years ago
|
||
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Comment 5•7 years ago
|
||
ignore-this-changeset
Updated•7 years ago
|
| Assignee | ||
Comment 7•7 years ago
|
||
Depends on D24175
Updated•7 years ago
|
Comment 8•7 years ago
|
||
Comment 10•7 years ago
|
||
Backed out 2 changesets (Bug 1539779, Bug 1536790) for toolchain failure. On a CLOSED TREE
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=5ecdbfab88b4e6b32ba725a697991f7dfc986f03
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=236837016&repo=autoland
[task 2019-03-29T08:28:44.308Z] FAILED: : && /builds/worker/workspace/build/src/clang/bin/clang++ -stdlib=libc++ -target x86_64-darwin11 -mlinker-version=137 -B /builds/worker/workspace/build/src/cctools/bin -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -I/builds/worker/workspace/build/src/MacOSX10.11.sdk/usr/include -iframework /builds/worker/workspace/build/src/MacOSX10.11.sdk/System/Library/Frameworks -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -std=c++11 -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -fno-common -Woverloaded-virtual -Wno-nested-anon-types -O3 -DNDEBUG -arch x86_64 -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names -Wl,-syslibroot,/builds/worker/workspace/build/src/MacOSX10.11.sdk -Wl,-dead_strip -Wl,-dead_strip tools/clang/tools/extra/clang-tidy/tool/CMakeFiles/clang-tidy.dir/ClangTidyMain.cpp.o -o bin/clang-tidy -Wl,-rpath,@loader_path/../lib lib/libclangAST.a lib/libclangASTMatchers.a lib/libclangBasic.a lib/libclangTidy.a lib/libclangTidyAbseilModule.a lib/libclangTidyAndroidModule.a lib/libclangTidyBoostModule.a lib/libclangTidyBugproneModule.a lib/libclangTidyCERTModule.a lib/libclangTidyCppCoreGuidelinesModule.a lib/libclangTidyFuchsiaModule.a lib/libclangTidyGoogleModule.a lib/libclangTidyHICPPModule.a lib/libclangTidyLLVMModule.a lib/libclangTidyMiscModule.a lib/libclangTidyModernizeModule.a lib/libclangTidyMozillaModule.a lib/libclangTidyObjCModule.a lib/libclangTidyPerformanceModule.a lib/libclangTidyPortabilityModule.a lib/libclangTidyReadabilityModule.a lib/libclangTidyZirconModule.a lib/libclangTooling.a lib/libclangToolingCore.a lib/libclangAST.a lib/libclangASTMatchers.a lib/libclangBasic.a lib/libclangTidy.a lib/libclangTidyAbseilModule.a lib/libclangTidyAndroidModule.a lib/libclangTidyBoostModule.a lib/libclangTidyBugproneModule.a lib/libclangTidyCERTModule.a lib/libclangTidyCppCoreGuidelinesModule.a lib/libclangTidyFuchsiaModule.a lib/libclangTidyGoogleModule.a lib/libclangTidyHICPPModule.a lib/libclangTidyLLVMModule.a lib/libclangTidyMiscModule.a lib/libclangTidyModernizeModule.a lib/libclangTidyMozillaModule.a lib/libclangTidyObjCModule.a lib/libclangTidyPerformanceModule.a lib/libclangTidyPortabilityModule.a lib/libclangTidyReadabilityModule.a lib/libclangTidyZirconModule.a lib/libclangTooling.a lib/libclangToolingCore.a lib/libclangTidyBugproneModule.a lib/libclangTidyCppCoreGuidelinesModule.a lib/libclangTidyGoogleModule.a lib/libclangTidyMiscModule.a lib/libclangTidyModernizeModule.a lib/libclangTidyReadabilityModule.a lib/libclangTidyUtils.a lib/libclangTidy.a lib/libclangTooling.a lib/libclangStaticAnalyzerFrontend.a lib/libclangStaticAnalyzerCheckers.a lib/libclangStaticAnalyzerCore.a lib/libclangCrossTU.a lib/libclangIndex.a lib/libclangFormat.a lib/libclangToolingInclusions.a lib/libclangToolingCore.a lib/libclangFrontend.a lib/libclangDriver.a lib/libclangParse.a lib/libclangRewrite.a lib/libclangSerialization.a lib/libclangSema.a lib/libclangEdit.a lib/libclangAnalysis.a lib/libclangASTMatchers.a lib/libclangAST.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVM.dylib && :
[task 2019-03-29T08:28:44.308Z] Undefined symbols for architecture x86_64:
[task 2019-03-29T08:28:44.308Z] "clang::tidy::MPIModuleAnchorSource", referenced from:
[task 2019-03-29T08:28:44.308Z] __GLOBAL__sub_I_ClangTidyMain.cpp in ClangTidyMain.cpp.o
[task 2019-03-29T08:28:44.308Z] ld: symbol(s) not found for architecture x86_64
[task 2019-03-29T08:28:44.308Z] clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
[task 2019-03-29T08:28:57.793Z] ninja: build stopped: subcommand failed.
[task 2019-03-29T08:28:57.818Z] Traceback (most recent call last):
[task 2019-03-29T08:28:57.818Z] File "./build-clang.py", line 758, in <module>
[task 2019-03-29T08:28:57.818Z] build_type, assertions, python_path, gcc_dir, libcxx_include_dir)
[task 2019-03-29T08:28:57.818Z] File "./build-clang.py", line 326, in build_one_stage
[task 2019-03-29T08:28:57.818Z] build_package(build_dir, cmake_args)
[task 2019-03-29T08:28:57.818Z] File "./build-clang.py", line 76, in build_package
[task 2019-03-29T08:28:57.818Z] run_in(package_build_dir, ["ninja", "install"])
[task 2019-03-29T08:28:57.818Z] File "./build-clang.py", line 43, in run_in
[task 2019-03-29T08:28:57.818Z] check_run(args)
[task 2019-03-29T08:28:57.818Z] File "./build-clang.py", line 36, in check_run
[task 2019-03-29T08:28:57.818Z] assert r == 0
[task 2019-03-29T08:28:57.818Z] AssertionError
[fetches 2019-03-29T08:28:57.837Z] removing /builds/worker/workspace/build
[fetches 2019-03-29T08:28:58.885Z] finished
[taskcluster 2019-03-29 08:28:59.280Z] === Task Finished ===
[taskcluster 2019-03-29 08:29:00.369Z] Unsuccessful task run with exit code: 1 completed in 909.582 seconds
Updated•7 years ago
|
| Assignee | ||
Updated•7 years ago
|
Comment 11•7 years ago
|
||
Landed manually here: https://hg.mozilla.org/integration/autoland/rev/9eb7867c1dd431f6effdd99bfea5c8a003ebb730
Comment 12•7 years ago
|
||
Backed out 3 changesets (bug 1538060, bug 1539779, bug 1536790) for causing clang-tidy bustages
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=237027527&revision=7d058f3174e5b7b6558e944137558ad501ec4a17
backout: https://hg.mozilla.org/integration/autoland/rev/825e93bb4b136234d46dfb8acc70cde7f0446ab8
| Assignee | ||
Comment 13•7 years ago
|
||
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5395d54a7d1
https://hg.mozilla.org/mozilla-central/rev/20b1524329bb
| Assignee | ||
Updated•7 years ago
|
Updated•7 years ago
|
Updated•4 years ago
|
Description
•