Closed Bug 1664747 Opened 6 years ago Closed 6 years ago

Fix the issues found by the bugprone-redundant-branch-condition checker

Categories

(Developer Infrastructure :: Source Code Analysis, task)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 external file)

Evaluating https://clang.llvm.org/extra/clang-tidy/checks/bugprone-redundant-branch-condition.html
found 3 issues

Fixed with:

./mach static-analysis check --checks="-*, bugprone-redundant-branch-condition" --fix -j 12
Summary: Fix the bugprone-redundant-branch-condition warning → Fix the issue found by the bugprone-redundant-branch-condition checker
Assignee: nobody → sledru
Status: NEW → ASSIGNED

New in clang-12

Summary: Fix the issue found by the bugprone-redundant-branch-condition checker → Fix the issues found by the bugprone-redundant-branch-condition checker
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/651e68f628d0 Remove some duplicate if ("bugprone-redundant-branch-condition" warning) r=emilio,andi

https://hg.mozilla.org/mozilla-central/rev/651e68f628d0

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: