Closed
Bug 1614139
Opened 6 years ago
Closed 6 years ago
nsPipe3.cpp: copy constructor should not be declared explicit
Categories
(Developer Infrastructure :: Source Code Analysis, task)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox75 fixed)
RESOLVED
FIXED
mozilla75
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: tuan.mate, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=C++])
Attachments
(1 external file, 1 obsolete file)
Filling as a good first bug to learn workflows.
copy constructor should not be declared explicit
https://searchfox.org/mozilla-central/source/xpcom/io/nsPipe3.cpp#159
As the change is trivial, it is just to learn how to contribute to Firefox.
Found by http://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html
Comment 1•6 years ago
|
||
Hi. I would like to work on this.
| Reporter | ||
Comment 2•6 years ago
|
||
Sure Please provide a patch
Updated•6 years ago
|
Assignee: nobody → tuan.mate
Status: NEW → ASSIGNED
Updated•6 years ago
|
Attachment #9126241 -
Attachment is obsolete: true
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8e18b9d4caae
Copy constructor of nsPipeInputStream should not be declared explicit. r=froydnj
Comment 6•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox75:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Updated•4 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•