+++ This bug was initially created as a clone of Bug #1713520 +++

Filling as a good first bug to learn workflows.

do not use 'else' after 'break':
https://searchfox.org/mozilla-central/source/layout/base/nsFrameTraversal.cpp#257-261

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

and please fix also:
https://searchfox.org/mozilla-central/rev/5977b6fdebe32451ada35fa2cbd7c0752cfea982/layout/base/nsFrameTraversal.cpp#306-310

(same same)

Working on this

Removed else after break

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jaygala260, could you have a look please?
For more information, please visit auto_nag documentation.

Updated author information with bugzilla nick and email. Hit bug 1718540 in the process.

Comment on attachment 9229194 [details]
Bug 1713521 - Deal with empty diff_commits in submit. r=zeid,glob

Revision D118922 was moved to bug 1718540. Setting attachment 9229194 [details] to obsolete.

https://hg.mozilla.org/mozilla-central/rev/3cb9a3daa264

Bug 1713521: Removed 'else' after 'break' from lines 257-261

jaygala260 : this bug was fixed two months ;)

Comment on attachment 9237902 [details]
Bug 1713521 - removed 'else' after 'break' at lines 257-261. r?emilio

Revision D123590 was moved to bug 1727562. Setting attachment 9237902 [details] to obsolete.

ran mach clang-format -p layout/base/nsFrameTraversal.cpp and ./mach lint --warnings --outgoing, 0 errors were found

Depends on D123648