Closed Bug 1930779 Opened 1 year ago Closed 1 year ago

ruff: tools/update-verify/scripts/async_download.py: Useless `return` statement at end of function

Categories

(Developer Infrastructure :: Lint and Formatting, task)

Tracking

(firefox137 fixed)

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: Sylvestre, Assigned: abe, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=python])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

Useless return statement at end of function PLR1711 (ruff)
https://searchfox.org/mozilla-central/source/tools/update-verify/scripts/async_download.py#349

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by https://docs.astral.sh/ruff/rules/useless-return/

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Assignee: nobody → abe
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f845deef66ae Remove useless return statement in async_download.py. r=sylvestre DONTBUILD

Do you want more good first bugs? :)

Possibly :)
With good mentorship, I'd be happy to take on a more challenging ticket :-)

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

(In reply to abe hanoka from comment #4)

Possibly :)
With good mentorship, I'd be happy to take on a more challenging ticket :-)

https://bugzilla.mozilla.org/show_bug.cgi?id=1209390 looks interesting :)

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: