clang 23 ERROR - /builds/worker/checkouts/gecko/security/nss/lib/freebl/lowhash_vector.c:24:19: error: variable 'blLib' set but not used [-Werror,-Wunused-but-set-global]
Categories
(NSS :: Libraries, defect)
Tracking
(nss 3.129)
| Tracking | Status | |
|---|---|---|
| nss | --- | 3.129 |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 3 open bugs)
Details
(Keywords: intermittent-failure)
Attachments
(1 external file)
clang 23 added -Wunused-but-set-global, which breaks the NSS build:
security/nss/lib/freebl/lowhash_vector.c:24:19: error: variable 'blLib'
set but not used [-Werror,-Wunused-but-set-global]
The statics blLib and libraryName in lib/freebl/lowhash_vector.c are only
ever assigned in freebl_LoadDSO() and never read. The full loader.c reads
them from BL_Unload(), but this stripped-down variant has no unload path,
so removing them is behaviour-neutral.
Patch: remove the two write-only statics.
| Assignee | ||
Comment 1•1 month ago
|
||
clang 23's new -Wunused-but-set-global fails the build:
security/nss/lib/freebl/lowhash_vector.c:24:19: error: variable 'blLib'
set but not used [-Werror,-Wunused-but-set-global]
Both statics are only ever assigned in freebl_LoadDSO(). The full loader.c
reads them from BL_Unload(), but this stripped-down variant has no unload
path, so dropping them is behaviour-neutral.
Comment 2•1 month ago
|
||
The severity field is not set for this bug.
:anna.weine, could you have a look please?
For more information, please visit BugBot documentation.
Updated•1 month ago
|
Pushed by jschanck@mozilla.com:
https://hg.mozilla.org/projects/nss/rev/ca25cbbedf63
Remove write-only blLib and libraryName statics from freebl's lowhash_vector r=nss-reviewers,jschanck
Comment 4•1 month ago
|
||
Comment 5•1 month ago
|
||
You won't see the fix on mozilla-central until NSS is updated in bug 2066767
| Comment hidden (Intermittent Failures Robot) |
Updated•1 month ago
|
Updated•1 month ago
|
Updated•1 month ago
|
| Comment hidden (Intermittent Failures Robot) |
Description
•