Closed Bug 2081115 Opened 11 days ago Closed 3 days ago

Remove the unreachable code after the switch in APZBridge::ReceiveInputEvent

Categories

(Core :: Panning and Zooming, defect, P3)

defect

Tracking

()

RESOLVED FIXED
160 Branch
Tracking Status
firefox-esr153 --- unaffected
firefox158 --- unaffected
firefox159 --- wontfix
firefox160 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 external file)

Coverity CID 1702966 (Structurally dead code).

In APZBridge::ReceiveInputEvent(WidgetInputEvent&, ...), every case of the switch on aEvent.mClass returns, including default, so the trailing MOZ_ASSERT_UNREACHABLE / SetStatusAsConsumeNoDefault / return can never run. The code is old; the CID is new because bug 2070702 renamed the file.

Type: task → defect
Keywords: regression
Regressed by: 2070702

Every case of the switch on the event class returns, including the
default one, so the code after it can never run.

Assignee: nobody → sledru
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 2070702

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(botond)
Type: task → defect
Flags: needinfo?(botond)
Priority: -- → P3
Pushed by sledru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e1ac6e4d7aa6 https://hg.mozilla.org/integration/autoland/rev/df8348f93c57 Remove the unreachable tail of APZBridge::ReceiveInputEvent (Coverity CID 1702966) r=hiro

The severity field is not set for this bug.
:botond, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(botond)
Severity: -- → S3
Flags: needinfo?(botond)
Status: ASSIGNED → RESOLVED
Closed: 3 days ago
Resolution: --- → FIXED
Target Milestone: --- → 160 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: