bryner's code in nsGlobalWindow::SaveWindowState uses CopyJSProperties which uses JS_Enumerate to list the enumerable ids in the window object. What we really want are the enumerables, which include DOM standard objects, plus the non-enumerable standard core language classes and utilities (Date, parseInt, etc.). This gives the desired transparency, so users can decorate String.prototype, e.g., and find the added methods on fast-back. Since the DOM code uses JS_ResolveStandardClass to lazily initialize the standard objects, we want a JS_EnumerateResolvedStandardClasses API. I'll change the bfcache code to use this new API, as well as add the API, all under this bug, if that's ok. /be

Easy enough to write a testcase. You could even automate the navigation using an iframe and theFrame.history.back(), etc. /be

This patch fixes XML-related class name resolution to (a) use standard_class_atoms not standard_class_names, so they're included in enumerations; (b) split out a few init hooks for the QName variants, per bug 295606. It also implements JS_EnumerateResolvedStandardClasses, as promised. Next patch will use that API from the bfcache code. /be

Comment on attachment 186362 [details] [diff] [review] proposed fix r=shaver.

Comment on attachment 186362 [details] [diff] [review] proposed fix I checked this in earlier today. /be

Comment on attachment 186446 [details] [diff] [review] patch to use the new JS API sr=jst

Comment on attachment 186446 [details] [diff] [review] patch to use the new JS API r=me if you're sure |props| will always be non-null under normal conditions

(In reply to comment #7) > (From update of attachment 186446 [details] [diff] [review] [edit]) > r=me if you're sure |props| will always be non-null under normal conditions Null or false return from a JS API that takes a cx first argument and allocates memory or does anything that might throw a JS error/exception means that the API call failed, always. Checked in, without some printfs I added to verify it worked, and with a fix to jsapi.c, to avoid resolving all the not-yet-resolved standard class names! /be