Closed
Bug 472025
Opened 17 years ago
Closed 17 years ago
Should use LONG_PTR for plugin code due to Win64
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: m_kato, Assigned: m_kato)
References
Details
Attachments
(1 file)
|
15.43 KB,
patch
|
jaas
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
Most window proc code uses LONG type and Set/GetWindowLong(). For 64-bit, we should use LONG_PTR and Set/GetWindowLongPtr().
VC8 and Latest SDK have this defines.
| Assignee | ||
Updated•17 years ago
|
Attachment #355270 -
Flags: review?(joshmoz)
Comment on attachment 355270 [details] [diff] [review]
patch v1
Looks OK to me but I don't know much about Windows. Thanks for doing this.
Attachment #355270 -
Flags: review?(joshmoz)
Attachment #355270 -
Flags: review?(bent.mozilla)
Attachment #355270 -
Flags: review+
Attachment #355270 -
Flags: review?(bent.mozilla) → superreview?(jst)
Updated•17 years ago
|
Attachment #355270 -
Flags: superreview?(jst) → superreview+
pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/23adb1fb2e1b
Thanks!
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•