Closed
Bug 560138
Opened 16 years ago
Closed 16 years ago
mismatch use of new[] with delete in CData::Create
Categories
(Core :: js-ctypes, defect, P1)
Core
js-ctypes
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
|
528 bytes,
patch
|
dwitte
:
review-
|
Details | Diff | Splinter Review |
5113 CData::Create(JSContext* cx,
5166 data = new char[size];
5183 delete data;
Updated•16 years ago
|
Assignee: nobody → dwitte
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee: dwitte → timeless
Attachment #439860 -
Flags: review?(dwitte)
Comment 2•16 years ago
|
||
Comment on attachment 439860 [details] [diff] [review]
patch
r=dwitte
Attachment #439860 -
Flags: review?(dwitte) → review+
Comment 3•16 years ago
|
||
Comment on attachment 439860 [details] [diff] [review]
patch
Waitasec, you (mis)matched the wrong one:
This one also needs matching: http://mxr.mozilla.org/mozilla-central/source/js/src/ctypes/CTypes.cpp#5183
r=dwitte for that one instead. ;)
Attachment #439860 -
Flags: review+ → review-
Comment 4•16 years ago
|
||
Also, when you land, please do so on TM rather than m-c.
Comment 5•16 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/d87701b07ca9
Pushed corrected fix.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•