Closed
Bug 637187
Opened 15 years ago
Closed 15 years ago
Unused variable in DocumentViewerImpl::Open
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 637864
People
(Reporter: Ms2ger, Assigned: Ms2ger)
References
Details
(Whiteboard: [build_warning])
Attachments
(3 files)
|
938 bytes,
patch
|
azakai
:
review-
|
Details | Diff | Splinter Review |
|
1.04 KB,
patch
|
azakai
:
review+
bzbarsky
:
review-
|
Details | Diff | Splinter Review |
|
1.09 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #515500 -
Flags: review?(azakai)
Flags: in-testsuite-
Comment 1•15 years ago
|
||
Comment on attachment 515500 [details] [diff] [review]
Patch v1
Good find. Sorry that my patch added a warning here.
Hmm, I think we should do something even in opt builds, so we could have
NS_ENSURE_SUCCESS(rv, rv);
instead of
NS_ABORT_IF_FALSE(NS_SUCCEEDED(rv), "failed in getting the root view");
but I am not a peer of this code (list: https://wiki.mozilla.org/Modules/Core ).
Attachment #515500 -
Flags: review?(azakai) → review-
Comment 3•15 years ago
|
||
Comment on attachment 515943 [details] [diff] [review]
Patch v2
Looks great to me. But as I said above, a peer of this code will need to review this as well.
Attachment #515943 -
Flags: review?(azakai) → review+
| Assignee | ||
Updated•15 years ago
|
Attachment #515943 -
Flags: review?(bzbarsky)
Comment 4•15 years ago
|
||
Comment on attachment 515943 [details] [diff] [review]
Patch v2
How about we stop pretending that GetRootView can return something other than NS_OK and wasting cycles on it instead? ;)
Attachment #515943 -
Flags: review?(bzbarsky) → review-
| Assignee | ||
Comment 5•15 years ago
|
||
Attachment #515985 -
Flags: review?(bzbarsky)
Comment 6•15 years ago
|
||
Comment on attachment 515985 [details] [diff] [review]
Unused variable in DocumentViewerImpl::Open
r=me
Attachment #515985 -
Flags: review?(bzbarsky) → review+
| Assignee | ||
Updated•15 years ago
|
Depends on: post2.0
Whiteboard: [build_warning][needs review] → [build_warning]
| Assignee | ||
Updated•15 years ago
|
Whiteboard: [build_warning] → [build_warning][needs landing]
| Assignee | ||
Updated•15 years ago
|
Whiteboard: [build_warning][needs landing] → [build_warning]
You need to log in
before you can comment on or make changes to this bug.
Description
•