Closed Bug 640757 Opened 15 years ago Closed 10 years ago

NSS code review for Win64 (LLP64) issues

Categories

(NSS :: Libraries, defect)

x86_64
Windows
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: briansmith, Unassigned)

References

Details

We want to ship 64-bit Firefox on Windows. I want to verify that here are no places where sizeof(long) >= sizeof(size_t) in NSS. Part of this might include ensuring NSS builds on VS2010 without triggering any of the 64-bit compatibility warnings.
I've been building 32bit Firefox on VS2010 for quite some time (Win7 x64 OS) and don't recall seeing any 64bit compatibility warnings. I can post a build log of the NSS part of the build here if that'll help you.
Depends on: 487723
What is the status of this bug? We are creating a bunch of Windows 64-bit machines that will soon be showing up officially at tbpl.
Blocks: tracking_win64
No longer blocks: support-win64
AFAICT, no work has been done yet. I suspect that there will be changes needed because i vaguely recollect there are a few cases where sizeof(long) >= sizeof(size_t) is assumed, at least.
Martin, do we still need someone to review the NSS code for Win64 compat issues? We have had official Win64 builds since Firefox 43 (December 2015).
Flags: needinfo?(martin.thomson)
OS: Windows Vista → Windows
Hardly. If there are compat issues, we will deal with them as they arise. I've done some review of integer issues, but given that we've been using this for a while, better to deal with things on a case-by-case basis.
Flags: needinfo?(martin.thomson)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.