Closed
Bug 881978
Opened 13 years ago
Closed 13 years ago
[webvtt] Move WebVTTLoadListener's call backs to be private
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla24
People
(Reporter: reyre, Assigned: caitlin.potter)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.02 KB,
patch
|
rillian
:
review+
reyre
:
feedback+
|
Details | Diff | Splinter Review |
Right now WebVTTLoadListener's OnParsedCue() and OnParsedError() callbacks are public. They do not need to be.
public:
void OnParsedCue(webvtt_cue* aCue);
void OnReportError(uint32_t aLine, uint32_t aCol, webvtt_error aError);
| Reporter | ||
Updated•13 years ago
|
Blocks: old-webvtt
| Assignee | ||
Updated•13 years ago
|
Assignee: nobody → caitlin.potter
| Assignee | ||
Comment 1•13 years ago
|
||
Quick patch to privatize the parsed cue/error handlers. Blocking on 881475 only because of the slightly changed OnReportError signature.
Let me know if it needs comments or something.
Attachment #761250 -
Flags: review?(giles)
Attachment #761250 -
Flags: feedback?(rick.eyre)
| Assignee | ||
Comment 2•13 years ago
|
||
Minor fixup, that is all
Attachment #761250 -
Attachment is obsolete: true
Attachment #761250 -
Flags: review?(giles)
Attachment #761250 -
Flags: feedback?(rick.eyre)
Attachment #761251 -
Flags: review?(giles)
Attachment #761251 -
Flags: feedback?(rick.eyre)
| Reporter | ||
Comment 3•13 years ago
|
||
Comment on attachment 761251 [details] [diff] [review]
Make WebVTTLoadListener callbacks private. V2
Review of attachment 761251 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me.
Attachment #761251 -
Flags: feedback?(rick.eyre) → feedback+
Comment 4•13 years ago
|
||
Comment on attachment 761251 [details] [diff] [review]
Make WebVTTLoadListener callbacks private. V2
Review of attachment 761251 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, thanks.
Attachment #761251 -
Flags: review?(giles) → review+
Comment 5•13 years ago
|
||
Comment 6•13 years ago
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in
before you can comment on or make changes to this bug.
Description
•