Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-Commit Hooks #786

Closed
vorburger opened this issue Sep 24, 2023 · 1 comment
Closed

Pre-Commit Hooks #786

vorburger opened this issue Sep 24, 2023 · 1 comment
Assignees
@vorburger

Comments

@vorburger
Copy link
Collaborator

The goal of this issue is to set up https://pre-commit.com.

Like https://github.com/enola-dev/enola/blob/main/.pre-commit-config.yaml

With https://pre-commit.ci.

PR #785 proposed initial configuration.
@vorburger vorburger self-assigned this Sep 24, 2023
vorburger added a commit that referenced this issue Sep 24, 2023
@vorburger
docs: Add Pre-Commit Hooks badge to README (see #786)
9cd411f 
[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/MariaDB4j/MariaDB4j/main.svg)](https://results.pre-commit.ci/latest/github/MariaDB4j/MariaDB4j/main)
@vorburger vorburger mentioned this issue Sep 24, 2023
Merged
vorburger added a commit to vorburger/MariaDB4j that referenced this issue Sep 24, 2023
@vorburger
chore: Remove Checkstyle from Pre-Commit (see MariaDB4j#786)
fb61b58 
Because Checkstyle runs as part of the Maven build instead of Pre-Commit.

Also exclude DBs + mvnw from Pre-Commit.
vorburger added a commit to vorburger/MariaDB4j that referenced this issue Sep 24, 2023
@vorburger
fix: Remove trailing whitespaces from many files (for MariaDB4j#786)
b382f16 
All of these changes were made by running `pre-commit run --all-files`.
@vorburger vorburger mentioned this issue Sep 24, 2023
Merged
vorburger added a commit to vorburger/MariaDB4j that referenced this issue Sep 24, 2023
@vorburger
chore: Remove shellcheck from Pre-Commit (see MariaDB4j#786)
e44bf74 
This project doesn't really contain bash shell scripts anyway
(outside of DBs/, which are out of our control), and `shellcheck`
is not available on https://pre-commit.ci anyways.
vorburger added a commit that referenced this issue Sep 24, 2023
@vorburger
chore: Remove Checkstyle from Pre-Commit (see #786)
8eb48dc 
Because Checkstyle runs as part of the Maven build instead of Pre-Commit.

Also exclude DBs + mvnw from Pre-Commit.
vorburger added a commit that referenced this issue Sep 24, 2023
@vorburger
fix: Remove trailing whitespaces from many files (for #786)
a2bc9ea 
All of these changes were made by running `pre-commit run --all-files`.
vorburger added a commit that referenced this issue Sep 24, 2023
@vorburger
chore: Remove shellcheck from Pre-Commit (see #786)
5663f9a 
This project doesn't really contain bash shell scripts anyway
(outside of DBs/, which are out of our control), and `shellcheck`
is not available on https://pre-commit.ci anyways.
vorburger added a commit that referenced this issue Sep 24, 2023
@vorburger
docs: Add Pre-Commit Hooks badge to README (see #786)
fdd3871 
[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/MariaDB4j/MariaDB4j/main.svg)](https://results.pre-commit.ci/latest/github/MariaDB4j/MariaDB4j/main)
@vorburger
Copy link
Collaborator Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vorburger vorburger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vorburger