Fix error at UPR and Colbert Reranker on GPU #424
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #407
the
with torch.no_grad():
was missing.I added it.
Plus, calculate cosine similarity after colbert embedding is pretty slow.
So, change code to use numpy for calculating cosine similarity.
I tested UPR & Colbert at H100 instance.
Plus, the colbert score did not change at all. Worked perfectly.