Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor existing metric python files with input schema #667

Merged
merged 52 commits into from
Sep 11, 2024
Merged

Conversation

Eastsidegunn
Copy link
Contributor

@Eastsidegunn Eastsidegunn commented Sep 2, 2024

close #655

@Eastsidegunn
Copy link
Contributor Author

What do you think about name of Payload?

Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Your code breaks something. The test code is not passing.

autorag/schema/payload.py Outdated Show resolved Hide resolved
autorag/schema/payload.py Outdated Show resolved Hide resolved
autorag/evaluation/retrieval.py Outdated Show resolved Hide resolved
autorag/schema/payload.py Outdated Show resolved Hide resolved
autorag/nodes/generator/run.py Outdated Show resolved Hide resolved
@vkehfdl1 vkehfdl1 linked an issue Sep 2, 2024 that may be closed by this pull request
@vkehfdl1
Copy link
Contributor

vkehfdl1 commented Sep 2, 2024

There was an typo at closing issue.
You try to close another issue ㅋㅋㅋㅋㅋㅋㅋㅋ

autorag/schema/metricinput.py Outdated Show resolved Hide resolved
autorag/evaluation/retrieval_contents.py Outdated Show resolved Hide resolved
@vkehfdl1
Copy link
Contributor

vkehfdl1 commented Sep 9, 2024

@Eastsidegunn You didn't resolve above two conversations yet.
Plus, please check "resolve conversation" after you solve that.

Copy link
Contributor

@vkehfdl1 vkehfdl1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This is the commit yeah
Sexy hot commit
JAX
Thanks to notice last commit message
This is how we work
AutoRAG
GOAT
Let's go!
Minji Naeun Gaeun Donggeon Let's go!

@vkehfdl1 vkehfdl1 enabled auto-merge (squash) September 11, 2024 10:20
@vkehfdl1 vkehfdl1 merged commit d965954 into main Sep 11, 2024
3 checks passed
@vkehfdl1 vkehfdl1 deleted the Feature/#655 branch September 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor existing metric python files with input schema
2 participants