refactor existing metric python files with input schema #667

Eastsidegunn · 2024-09-02T01:23:00Z

close #655

Eastsidegunn · 2024-09-02T01:25:27Z

What do you think about name of Payload?

vkehfdl1

Your code breaks something. The test code is not passing.

autorag/schema/payload.py

autorag/evaluation/retrieval.py

autorag/schema/payload.py

autorag/nodes/generator/run.py

vkehfdl1 · 2024-09-02T03:34:59Z

There was an typo at closing issue.
You try to close another issue ㅋㅋㅋㅋㅋㅋㅋㅋ

…ds', 'retrieval_contents') to ('retrieval_gt_contents', 'retrieved_ids', 'retrieved_contents')

…icInput schema from cls to self

…iables style

… directly)

…ds', 'retrieval_contents') to ('retrieval_gt_contents', 'retrieved_ids', 'retrieved_contents') in whole code.

autorag/schema/metricinput.py

autorag/evaluation/retrieval_contents.py

vkehfdl1 · 2024-09-09T01:25:05Z

@Eastsidegunn You didn't resolve above two conversations yet.
Plus, please check "resolve conversation" after you solve that.

…List[str]]

…etrieval_gt_contents to List[List[str]])

vkehfdl1

LGTM
This is the commit yeah
Sexy hot commit
JAX
Thanks to notice last commit message
This is how we work
AutoRAG
GOAT
Let's go!
Minji Naeun Gaeun Donggeon Let's go!

Eastsidegunn added 12 commits August 26, 2024 20:38

add Payload data schema

fa666c6

edit Payload data schema

e2f85ad

edit test code with payload schema

c9cc00a

edit generation.py with payload schema

096da36

edit retrieval.py with payload schema

54156f2

edit retrieval_contents.py with payload schema

e34ddc9

edit generator/run.py with payload schema

f9898a7

edit queryexpansion/run.py with payload schema

804e788

edit retrieval/run.py with payload schema

8a904ab

edit passagereranker/run.py with payload schema

f534b0c

edit passagefilter/run.py with payload schema

16a3bdc

edit passagepromptmaker/run.py with payload schema

223abd8

Eastsidegunn requested a review from vkehfdl1 September 2, 2024 01:23

Eastsidegunn and others added 4 commits September 2, 2024 11:28

Merge branch 'main' into Feature/#655

88222c1

edit query_expansion with Payload

c046118

edit promptmaker with Payload

3d38e22

edit passageaugmenter with Payload

91ec088

vkehfdl1 requested changes Sep 2, 2024

View reviewed changes

vkehfdl1 linked an issue Sep 2, 2024 that may be closed by this pull request

refactor existing metric python files with input schema #655

Closed

Eastsidegunn and others added 9 commits September 2, 2024 17:52

rename Payload to MetricInput

ae6d3d6

Merge branch 'main' into Feature/#655

ac1e56e

rename Payload to MetricInput

abaf150

edit test.py with MetricInput

513a56a

add is_fileds_notnone MetricInput method

f172034

edit run, evaluation code for pre-retrieval, retrieval process

127da1c

edit run, evaluation code for post process

d5921f6

Merge branch 'refs/heads/main' into Feature/#655

a16eff1

Merge remote-tracking branch 'origin/Feature/#655' into Feature/#655

349566f

vkehfdl1 and others added 11 commits September 8, 2024 10:02

Merge branch 'main' into Feature/#655

9353425

Renamed MetricInput class variable from ('gt_contents', 'retireval_i…

8b28c02

…ds', 'retrieval_contents') to ('retrieval_gt_contents', 'retrieved_ids', 'retrieved_contents')

Renamed first parameter of is_fields_notnone method included in Metr…

f3e3dc0

…icInput schema from cls to self

make _check_list method of MetricInput schema to staticmethod

c4ce922

rename autorag_metric_loop

bfdb91d

modify metric fields_to_check params with pre-commit: MetricInput var…

d8fdf54

…iables style

modify setattr function to more intutive code style. (set attribution…

4ae5989

… directly)

modify code to use autorag.utils.util to_list func

872050e

Merge remote-tracking branch 'origin/Feature/#655' into Feature/#655

58a0b6e

rename variance name 'payloads' to metric_inputs in whole code

a5cb92b

Renamed MetricInput class variable from ('gt_contents', 'retireval_i…

832ca97

…ds', 'retrieval_contents') to ('retrieval_gt_contents', 'retrieved_ids', 'retrieved_contents') in whole code.

Eastsidegunn requested a review from vkehfdl1 September 8, 2024 16:40

vkehfdl1 requested changes Sep 9, 2024

View reviewed changes

autorag/schema/metricinput.py Outdated Show resolved Hide resolved

autorag/evaluation/retrieval_contents.py Outdated Show resolved Hide resolved

Eastsidegunn and others added 6 commits September 9, 2024 11:09

refactor MetricInput from_dataframe method

f28a47d

Refactor: Extract type_checks dictionary from MetricInput class

42583f6

Merge branch 'main' into Feature/#655

8eb65bf

Modify the type hint of retrieval_gt_contents from List[str] to List[…

82e2f8b

…List[str]]

Merge branch 'refs/heads/main' into Feature/#655

084c06b

Merge remote-tracking branch 'origin/Feature/#655' into Feature/#655

1023f26

Eastsidegunn requested a review from vkehfdl1 September 11, 2024 05:25

vkehfdl1 and others added 5 commits September 11, 2024 07:46

Merge branch 'main' into Feature/#655

98aa386

- Fixed test_single_token_f1 bug introduced in last commit(changing r…

ec61c83

…etrieval_gt_contents to List[List[str]])

Merge remote-tracking branch 'origin/Feature/#655' into Feature/#655

b4664bb

- Fixed test_single_token_f1 bug introduced in last commit(changing r…

5a61095

…etrieval_gt_contents to List[List[str]])

Merge branch 'main' into Feature/#655

e608857

vkehfdl1 approved these changes Sep 11, 2024

View reviewed changes

vkehfdl1 enabled auto-merge (squash) September 11, 2024 10:20

vkehfdl1 merged commit d965954 into main Sep 11, 2024
3 checks passed

vkehfdl1 deleted the Feature/#655 branch September 11, 2024 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor existing metric python files with input schema #667

refactor existing metric python files with input schema #667

Eastsidegunn commented Sep 2, 2024 •

edited by vkehfdl1

Loading

Eastsidegunn commented Sep 2, 2024

vkehfdl1 left a comment

vkehfdl1 commented Sep 2, 2024

vkehfdl1 commented Sep 9, 2024

vkehfdl1 left a comment

refactor existing metric python files with input schema #667

refactor existing metric python files with input schema #667

Conversation

Eastsidegunn commented Sep 2, 2024 • edited by vkehfdl1 Loading

Eastsidegunn commented Sep 2, 2024

vkehfdl1 left a comment

Choose a reason for hiding this comment

vkehfdl1 commented Sep 2, 2024

vkehfdl1 commented Sep 9, 2024

vkehfdl1 left a comment

Choose a reason for hiding this comment

Eastsidegunn commented Sep 2, 2024 •

edited by vkehfdl1

Loading