Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Contract Interaction / Deployment - Metrics - When I have the redesign toggle disabled I still see contract interactions/deployments with redesigned_confirmation in Metrics Events #28339

Open
seaona opened this issue Nov 7, 2024 · 2 comments · May be fixed by #28385
Assignees
Labels
regression-prod-12.6.0 Regression bug that was found in production in release 12.6.0 regression-RC-12.7.0 release-blocker This bug is blocking the next release team-confirmations Push issues to confirmations team type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Nov 7, 2024

Describe the bug

When I have the redesign toggle disabled I still see contract interactions/deployments with `redesigned_confirmation in Metrics Events.

[Update]

  • In current production 12.6.0, the issue is that we always see ui_customizations as null no matter if I have the Transactions Enabled or disabled (see picture)
  • in 12.7.0, we always see ui_customizations as redesigned_confirmation no matter if I have the Transactions Enabled or disabled

Expected behavior

12.6.0

Screenshot from 2024-11-07 09-43-33

12.7.0

metrics-contract-interaction-deployment.mp4

Screenshots/Recordings

No response

Steps to reproduce

  1. Enable Metrics
  2. Disable Transactions Redesign from Settings
  3. Trigger a Contract Deployment/ Contract Interaction
  4. See metrics event with ui_customization: redesigned_confirmation

Error messages or log output

No response

Detection stage

In production (default) + RC (there is a different issue on each version, affecting this same metrics)

Version

12.6.0 12.7.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response

@seaona seaona added the type-bug label Nov 7, 2024
@metamaskbot metamaskbot added the regression-prod-12.6.0 Regression bug that was found in production in release 12.6.0 label Nov 7, 2024
@seaona seaona added regression-RC-12.7.0 regression-prod-12.6.0 Regression bug that was found in production in release 12.6.0 and removed regression-prod-12.6.0 Regression bug that was found in production in release 12.6.0 labels Nov 7, 2024
@seaona
Copy link
Contributor Author

seaona commented Nov 7, 2024

Update:

  • In current production 12.6.0, the issue is that we always see ui_customizations as null no matter if I have the Transactions Enabled or disabled (see picture)
  • in 12.7.0, we always see ui_customizations as redesigned_confirmation no matter if I have the Transactions Enabled or disabled

Screenshot from 2024-11-07 09-43-33

@seaona seaona added the release-blocker This bug is blocking the next release label Nov 7, 2024
@benjisclowder benjisclowder added the team-confirmations Push issues to confirmations team label Nov 7, 2024
@digiwand digiwand self-assigned this Nov 7, 2024
@sleepytanya
Copy link
Contributor

Related #28322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.6.0 Regression bug that was found in production in release 12.6.0 regression-RC-12.7.0 release-blocker This bug is blocking the next release team-confirmations Push issues to confirmations team type-bug
Projects
Status: To be fixed
Status: To be fixed
5 participants