Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch reliance on isMobile for mobile device UI detection #2072

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

timothycarambat
Copy link
Member

@timothycarambat timothycarambat commented Aug 8, 2024

Pull Request Type

  • ✨ feat
  • πŸ› fix
  • ♻️ refactor
  • πŸ’„ style
  • πŸ”¨ chore
  • πŸ“ docs

Relevant Issues

resolves #xxx

What is in this change?

  • Implement useIsMobile hook to replace all instances of isMobile from react-device-detect
  • The useIsMobile hook allows us to control the mobile breakpoint easier and also makes all UI that uses this hook reactive to screen size changes to switch between mobile and desktop views without refreshing the page
  • Fix a bug where the text input box for chatting was a fixed size and would go off the screen on mobile views (bug from implementing the AttachmentManager feature)

Additional Information

Developer Validations

  • I ran yarn lint from the root of the repo & committed changes
  • Relevant documentation has been updated
  • I have tested my code functionality
  • Docker build succeeds locally

@shatfield4 shatfield4 marked this pull request as ready for review August 9, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants