proj_normalize_for_visualization: check other left-handed orders, not… #4084
Conversation
| (&dir0 == &cs::AxisDirection::EAST && | ||
| &dir1 == &cs::AxisDirection::SOUTH) || | ||
| (&dir0 == &cs::AxisDirection::SOUTH && | ||
| &dir1 == &cs::AxisDirection::WEST) || | ||
| (&dir0 == &cs::AxisDirection::WEST && | ||
| &dir1 == &cs::AxisDirection::NORTH)) { |
There was a problem hiding this comment.
I'm not convinced that just switching the axis is enough for those 3 coordinate system. We should also presumably transform southing to northing, westing to easting, and make sure the final order is easting, northing
There was a problem hiding this comment.
That is also changing other problem, that westing-southing is displayed in QGIS with Antartica at the top. In that case moving up in the screen will make the coordinates decrease. Is that normal?
I do not mean that it should not be changed (well, I got used to it in South Africa). But the initial problem in QGIS was the mirroring effect.
There was a problem hiding this comment.
In that case moving up in the screen will make the coordinates decrease. Is that normal?
I guess so.
I believe all those coordinate systems should have easting,northing axis order after normalize_for_visualization. The native orders are just conventions to avoid specifying negative values, or other esoteric reasons, but ultimately you want your map with increasing eastings towards the right of the screen, and increasing northings towards the top of the screen
Maybe @thareUSGS can confirm for planetary CRS how maps in a CRS like IAU_2015:19901 "Mercury (2015) / Ographic" which has northing,westing should be displayed. I presume this should be transformed as easting,northing ?
There was a problem hiding this comment.
I believe all those coordinate systems should have easting,northing axis order after normalize_for_visualization. The native orders are just conventions to avoid specifying negative values, or other esoteric reasons, but ultimately you want your map with increasing eastings towards the right of the screen, and increasing northings towards the top of the screen
I have been thinking about this a bit more. Currently in QGIS (and also with this PR), using a WSU system, easting/westing is increasing towards the right of the screen, and northing/southing is increasing towards the top of the screen (for that reason Antarctica is at the top). I think in PROJ we cannot do anything to avoid it.
If QGIS wants to display Antarctica at the bottom with such CRS, it is something to be done in the display, QGIS.
|
The PROJ project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last two months and is being automatically marked as "stale". If you think this pull request should be merged, please check
|
|
While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 2 months. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the PROJ project can do to help push this PR forward please let us know how we can assist. |
ee35c72 to
6b5b72e
Compare
|
As we were talking in the code sprint, I think we cannot go further than this. In QGIS the user can rotate the scene in the status bar. But the mirror effect cannot be undone in QGIS. |
… only N-E
A few CRSs use left-handed orders other than N-E, like S-W in EPSG:5513