Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grass.pygrass: Fixed E402 in pygrass/utils #4759

Merged
merged 3 commits into from
Dec 8, 2024
Merged

grass.pygrass: Fixed E402 in pygrass/utils #4759

merged 3 commits into from
Dec 8, 2024

Conversation

arohanajit
Copy link
Contributor

Added noqa to imports at top in line with other fixes in the repo

@echoix
Copy link
Member

echoix commented Nov 25, 2024

@petrasovaa Is this the correct pattern here? I think so, but I am not certain enough to directly approve.

@github-actions github-actions bot added Python Related code is in Python libraries labels Nov 25, 2024
@arohanajit arohanajit changed the title pygrass: FIxed E402 in pygrass/utils grass.pygrass: FIxed E402 in pygrass/utils Nov 27, 2024
@echoix echoix changed the title grass.pygrass: FIxed E402 in pygrass/utils grass.pygrass: Fixed E402 in pygrass/utils Nov 27, 2024
@echoix
Copy link
Member

echoix commented Dec 3, 2024

(Conflict in .flake8 solved)

@arohanajit
Copy link
Contributor Author

@petrasovaa Is this the correct pattern here? I think so, but I am not certain enough to directly approve.

@echoix I made this change according to comments in this PR which was of similar nature: #4706 (review)

echoix
echoix reviewed Dec 5, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I remember now. In that case, I might suggest to move two imports out of the exclusion, if isort is happy and is correct.

In both cases it's good and I would agree to merge anyways.

echoix
echoix approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ever there's a problem with this that we couldn't think about, we'll adapt at that time.

@echoix echoix enabled auto-merge (squash) December 5, 2024 23:36
@echoix echoix merged commit 5b83fd8 into OSGeo:main Dec 8, 2024
26 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
libraries Python Related code is in Python
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@arohanajit @echoix