-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporal: Fix F401 Linter Warnings by Replacing Wildcard Imports with Explicit Imports in __init__.py #4736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it was done with the help of a tool the same way as the other PRs, it looks good to me. If there are some parts you'd want me to look more attentively in an IDE, tell me here before we merge
I basically listed out all function calls and added them. I had tried using GPT for this, but it misclassifies some functions like it did in a similar PR previously. Subsequently I ran isort on them |
If you use vscode, why not activate pylance/pyright? It'll discover the methods and modules and you won't have to fear hallucinations. You'll have the autocomplete suggestions feeded through the LSP protocol. |
I'll try to open it myself next time I'm on a computer with time for this. |
Got it! I'll try it out next time I have a similar PR |
@echoix I looked at it in iDE, and it matches the functions on the files |
I don't know how well we could check it, but is there a way to do a little double check on the gui tools that use this module? It's less used than grass.script, so it might be possible to search for all references. Recently there was an overlook that ended up having grass.script.named_colors not being exposed anymore, and a gui component wasn't working anymore. Since the gui code is poorly tested (I'm being generous here), we didn't catch it until a bug was filed. See #4825 and the issue it fixed. |
Addresses multiple F401 linter warnings in the init.py file by replacing wildcard imports with explicit imports and defining the all variable to specify the public API of the module.