[New] update element role mappings #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Pull Request Test Coverage Report for Build 10141393379Details
💛 - Coveralls |
676409d
to
047c969
Compare
|
@jlp-craigmorten is this PR semver patch or minor, do you think? |
Suspect at least a minor here: some of these mappings were likely revised or added in specs since their last manifestation in this project so a patch doesn’t quite feel appropriate as the introducing change wasn’t incorrect at the time. Pertinent parts of HTML-AAM changelog:
|
047c969
to
a69bbc4
Compare
a69bbc4
to
75803f7
Compare
75803f7
to
c151daf
Compare
ljharb
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #553
The mappings for
hgroup,s, andsearchelements are missing or are incorrect/outdated.This updates as so:
hgroupelement is now associated with thegrouprole and no longer associated with thegenericrole.selement is now associated with thedeletionrole.searchelement is now associated with thesearchrole.Relevant specs:
See also Web Platform Tests for HTML-AAM roles.