-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ignore patterns with non-ASCII Unicode literals aren't allowed #131
Comments
Could you include the full command you are running? |
I'm running just |
I'm just having a hard time understanding, because that error message to me implies that Is there anyway you can provide a full reproduction? I.e., the full command and a file that you are searching that causes the problem? |
The error message also implies that the pattern is over 6,000 characters. |
Yes, I also had difficulties to try to understand the error message. |
Thanks! To be clear, I can run To provide more context, if I run
In this case, it's expected behavior, because when Unicode mode is disabled, you lose the ability to search for Unicode string literals. (I can go into more gruesome detail here if anyone is curious, but it's actually a design decision in the regex engine, not Anyway, I kind of expect that there's some weirdness going on, so I shall look forward to more details. :-) Thank you for looking into it! |
It is something with .gitignore parsing - I can repro by running
yielding:
|
Ah, I got it now. The globber translates patterns to regexes and disables Unicode support. But this will fail if any literal is not an ASCII codepoint. |
Yes! I can confirm that. |
I get a similar error, I guess is my .gitignore file, but don't know how to search for '])# Cr'
|
fixed in |
When I do
rg <pattern-with-diacritics>
, I get:I also get that error when using this in combination with fzf, which is strange because there, rg output is only filenames, which has no non-ascii chars, as far as I know.
I'm on OSX 10.11.6, and my locale is en_US.UTF-8
The text was updated successfully, but these errors were encountered: