-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move termcolor to separate repository? #924
Comments
It might, but
Not sure. The issue volume for termcolor is quite low. The reason why it (and the other crates) are in the ripgrep repo is because it simplifies maintenance for me, which I attach a lot of value to. I'm not sure that there's too much else left to do for termcolor anyway. It will never grow beyond very basic color/styling support. It's probably ripe for a 1.0 release. |
I was using ripgrep on the default powershell terminal which has a blue background. The red with blue doesn't work well. It got me thinking that term colors for error / warning / good probably don't work well for some colorblind users. It would be pretty cool if we could somehow support colorblind cli tools out of the box. Anyway maybe this is an argument for terminal coloring being separated so functionality like that can be solved in one place? |
@gilescope Huh? This issue should be about process and maintenance. Specific features are entirely orthogonal. |
Good point. And the more I think of color blindness support, the more I think its better solved once at the OS level like iOS/Android do. |
We also move wincolor with it. Fixes #924
I've moved My intent is to release 1.0 imminently. |
Termcolor is the coloring crate used by Cargo (since June, 2017), which indicates to me that it should be or become the default recommended terminal coloring crate for Rust. Termcolor also handles Windows the most robustly out of all of the terminal coloring crates available.
For discoverability, should termcolor move to a separate repository?
The text was updated successfully, but these errors were encountered: