Make use of --new-resolver flag in bootstrap command #2486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmspzz
commented
Jun 14, 2018
Source/carthage/Bootstrap.swift
Outdated
| @@ -17,7 +17,9 @@ public struct BootstrapCommand: CommandProtocol { | |||
| if !FileManager.default.fileExists(atPath: project.resolvedCartfileURL.path) { | |||
| let formatting = options.checkoutOptions.colorOptions.formatting | |||
| carthage.println(formatting.bullets + "No Cartfile.resolved found, updating dependencies") | |||
| return project.updateDependencies(shouldCheckout: options.checkoutAfterUpdate, buildOptions: options.buildOptions) | |||
| return project.updateDependencies(shouldCheckout: options.checkoutAfterUpdate, | |||
| useNewResolver: options.useNewResolver, | |||
There was a problem hiding this comment.
No idea why it looks like this on Github, looks fine in Xcode.
There was a problem hiding this comment.
No idea why it looks like this on Github, looks fine in Xcode.
That's because GitHub treats a tab as 8 spaces by default. You can change that by ?ts=4 or ts=2 query.
By the way I think this should be formatted like this:
return project.updateDependencies(
shouldCheckout: options.checkoutAfterUpdate,
useNewResolver: options.useNewResolver,
buildOptions: options.buildOptions
)7438ad0
to
b0eef3b
Compare
|
@ikesyo Done |
mdiep
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.