Filter out improper directories passing as frameworks #2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91f9029
to
4233bb6
Compare
mdiep
approved these changes
May 1, 2018
|
This approach looks good to me. 👍 Do you want to try writing some tests for that function? If not, you can go ahead and merge. |
|
mdiep
approved these changes
May 2, 2018
|
Great work! |
This was referenced May 2, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same final purpose of #2432 but different implementation.
Note that in this version the user is not informed about the filtering.
It would be possible to pass in
self._projectEventsObserverfor logging.I will close #2432 or this PR depending on which one is chosen :)