Fix invalid lipo command in stripArchitectures() when embedding dSYMs #3155
Conversation
If the architectures argument is empty (because there are no architectures to be stripped), this method will produce and execute an invalid lipo command because it will contain no -remove arguments. To fix this, I make the method a no-op if the input list of architectures is empty.
There was a problem hiding this comment.
Looks great, thank you! We do something like this already in nonDestructivelyStripArchitectures but this impacts dSYM embedding via copyDebugSymbolsForFramework.
|
@elliottwilliams / @chriseplettsonos I realise this is merged in already, but I've been active on an open issue for a little while RE: invalid |
|
Indeed, I was actually experiencing the problem on the copy-frameworks phase. I imagine this should resolve those issues. |
|
Yeah, that looks right to me. Thanks for surfacing those issues – i've closed them. |
If the architectures argument is empty (because there are no architectures to be stripped), this method will produce and execute an invalid lipo command because it will contain no -remove arguments. To fix this, I make the method a no-op if the input list of architectures is empty.