Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: DWM packages and installation bug #421

Merged
merged 1 commit into from
Sep 16, 2024
Merged

fix: DWM packages and installation bug #421

merged 1 commit into from
Sep 16, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 16, 2024 •
edited
Loading

Pull Request

Title

DWM debian fixes

Type of Change

  • Bug fix

Description

  • Added run time dependencies from debian12 repo https://packages.debian.org/bookworm/dwm
  • Fixed a bug leading to script not executing due to package manager error
  • This bug is due to checking for apt-get and not apt in the common script and using apt in the dwm script. Switching from apt to apt-get resolved the issue.

Testing

Tested on a new debian12 install. Working as expected

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

@jeevithakannan2 jeevithakannan2 changed the title Fix packages fix: DWM packages and installation bug Sep 16, 2024
@jeevithakannan2 jeevithakannan2 mentioned this pull request Sep 16, 2024
Closed
mashrukk
mashrukk suggested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mashrukk mashrukk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeevithakannan2 In DisplayManager function add xrandr and xsetroot for all package managers if you can. If it's working on debian maybe it installs those packages with xorg and xinit. But it's needed for pacman xorg-xrandr xorg-xsetroot. I can't confirm about dnf and zypper.

@jeevithakannan2
Copy link
Contributor Author

Zypper is not implemented in the script. xrandr and xsetroot packages should be added in another PR as this PR only focuses on runtime dependency fixes. If xrandr and xsetroot is used in DWM Titus I will add them here. Can you please verify whether xrandr and xsetroot are used in DWM Titus?

@mashrukk
Copy link
Contributor

mashrukk commented Sep 16, 2024 •
edited
Loading

@jeevithakannan2 DWM Titus uses xsetroot for status bar here and here . I couldn't find any use of xrandr, so it may not be needed.

@jeevithakannan2
Copy link
Contributor Author

@jeevithakannan2 DWM Titus uses xsetroot for status bar here and here . I couldn't find any use of xrandr, so it may not be needed.

I thought the status bar was ported to slstatus

@ChrisTitusTech ChrisTitusTech merged commit 6d73e66 into ChrisTitusTech:main Sep 16, 2024
1 check passed
@jeevithakannan2 jeevithakannan2 deleted the dwm-debian-fix branch September 17, 2024 01:23
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashrukk mashrukk mashrukk requested changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DWM Fail on debian
3 participants
@jeevithakannan2 @mashrukk @ChrisTitusTech