Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement minimum TUI size #425

Merged
merged 3 commits into from
Sep 18, 2024
Merged

feat: Implement minimum TUI size #425

merged 3 commits into from
Sep 18, 2024

Conversation

jeevithakannan2
Copy link
Contributor

@jeevithakannan2 jeevithakannan2 commented Sep 16, 2024 •
edited
Loading

Pull Request

Title

Implement minimum TUI size

Type of Change

  • New feature
  • UI/UX improvement

Description

  • Display a warning message if the terminal size is small
  • Prevents entries from not appearing on screen. Refer issue Resizing window hides the text.  #242
  • The method to resolve the issue is to render the TUI only when the size of TUI is above a certain threshold

warning

Impact

  • Disables users from accessing the UI when the terminal size is small

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no errors/warnings/merge conflicts.

adamperkowski
adamperkowski suggested changes Sep 16, 2024
View reviewed changes
tui/src/state.rs Outdated Show resolved Hide resolved
@ChrisTitusTech @adamperkowski
Update tui/src/state.rs
1d9d2f8 
Co-authored-by: Adam Perkowski <adas1per@protonmail.com>
@nnyyxxxx
Copy link
Contributor

Nice! bashtop also has a feature like this.
image

@jeevithakannan2
Copy link
Contributor Author

I see, I think i should change Terminal size too small to current size. What do you think ?

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Sep 17, 2024 •
edited
Loading

I see, I think i should change Terminal size too small to current size. What do you think ?

No, the current version is fine how it is.

@jeevithakannan2 jeevithakannan2 mentioned this pull request Sep 17, 2024
Closed
@ChrisTitusTech ChrisTitusTech merged commit fde25af into ChrisTitusTech:main Sep 18, 2024
2 checks passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request UI/UX improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resizing window hides the text.
4 participants
@jeevithakannan2 @nnyyxxxx @ChrisTitusTech @adamperkowski