Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DNF configuration and Multimedia Support for fedora and other Redhat Distros #438

Merged
merged 8 commits into from
Sep 19, 2024
Merged

Added DNF configuration and Multimedia Support for fedora and other Redhat Distros #438

merged 8 commits into from
Sep 19, 2024

Conversation

Angxddeep
Copy link
Contributor

Pull Request

DNF Configuration & Multimedia Codecs

Just some essential DNF changes to at least make it usable and faster by a margin.
Also added installation support for multimedia codecs

Type of Change

  • New feature

Testing

Checked on my System, it works

Issue related to PR

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

adamperkowski
adamperkowski approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@adamperkowski adamperkowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could do a multimedia-codecs.sh in tabs/system-setup that would support other distros aswell.

@Angxddeep
Copy link
Contributor Author

Angxddeep commented Sep 17, 2024 •
edited
Loading

We could do a multimedia-codecs.sh in tabs/system-setup or tabs/utils that would support other distros aswell.

Most distros enable that on the setup, it's mostly a fedora thing they like to go for FOSS stuff and this is just checking the rpm-fusion nonfree and swapping things like ffmpeg-free with ffmpeg it's not that you can't already do media things its just getting some non-free stuff too

@adamperkowski
Copy link
Contributor

Most distros enable that on the setup

We want this tool to work on any distro, not most.
Arch Linux (a very popular distro), for example, doesn't bundle ffmpeg in base.

@nnyyxxxx
Copy link
Contributor

Most distros enable that on the setup

We want this tool to work on any distro, not most. Arch Linux (a very popular distro), for example, doesn't bundle ffmpeg in base.

I agree with Adam.

@ChrisTitusTech ChrisTitusTech merged commit 97576d2 into ChrisTitusTech:main Sep 19, 2024
2 checks passed
@ChrisTitusTech ChrisTitusTech added the enhancement New feature or request label Sep 19, 2024
@Angxddeep Angxddeep deleted the Testing-#2 branch September 19, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx left review comments

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dnf Setup
4 participants
@Angxddeep @adamperkowski @nnyyxxxx @ChrisTitusTech