Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI Workflow] Fix pr-label #441

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[CI Workflow] Fix pr-label #441

merged 2 commits into from
Sep 18, 2024

Conversation

MyDrift-user
Copy link
Contributor

@MyDrift-user MyDrift-user commented Sep 17, 2024 •
edited
Loading

Type of Change

  • Bug fix

Description

  • PR's that have text formatted as code crash the workflow due to it not being read as a plain text, therefore will have syntax errors.
  • switch from pull_request to pull_request_target bc of limited GITHUB_TOKEN permission.
  • other little enhancement

Testing

  • tested again on own repo

Issue related to PR

  • Resolves issues of workflows for pr labels

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@MyDrift-user
fix stuff
5e83ca5 
- enhance logic
- fix logic to get PR body as plain text
@MyDrift-user
add _target for forked repo support
63b7da4
nnyyxxxx
nnyyxxxx approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@nnyyxxxx nnyyxxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MyDrift-user
Copy link
Contributor Author

MyDrift-user commented Sep 18, 2024 •
edited
Loading

It does later on, that is just a declaration so it can easily be edited later.

Here the part:

if echo "$body" | grep -Eq "\- \[x\] ($pattern)"; then
              labels_to_add+=("$label")

you can see here where I tested it: https://github.com/MyDrift-user/mwm/pull/1

@adamperkowski
Copy link
Collaborator

It does later on

I was looking at a wrong file. That's why i deleted my comment.

@adamperkowski
Copy link
Collaborator

@MyDrift-user Check Discord.

@ChrisTitusTech ChrisTitusTech merged commit 5f042a0 into ChrisTitusTech:main Sep 18, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnyyxxxx nnyyxxxx nnyyxxxx approved these changes

@adamperkowski adamperkowski adamperkowski approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MyDrift-user @adamperkowski @ChrisTitusTech @nnyyxxxx