Add code understanding & testing point to Contributing Guidelines #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines. Co-authored-by: CodingWonders <CodingWonders@users.noreply.github.com> Co-authored-by: nnyyxxxx <nnyyxxxx@users.noreply.github.com>
CodingWonders
approved these changes
Sep 17, 2024
nnyyxxxx
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
As we have all seen our fair share of UNTESTED LLM Generated code, we all have decided to give our takes on it in this PR.
Keep in mind Adam is only making this PR because we have had our fair share of PR Makers denying and outright criticizing our reviews & being generally uncooperative when their WHOLE PR is LLM GENERATED.. Here are some examples: #447 #446 #430 #448 #453
nnyyxxxx
approved these changes
Sep 18, 2024
ChrisTitusTech
approved these changes
Sep 18, 2024
aa086d4
to
2ae8ad9
Compare
ChrisTitusTech
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
We've seen some non-tested LLM-generated PRs in the past few days that are a pain to review.
Adding this to the guidelines will save us some time not having to re-write bad, not working AI-generated code.
Checklist